← Back to issue list

requirements: update craft-parts to 1.0.1 (CRAFT-430, CRAFT-520)

View original Github issue

Metadata

Project
charmcraft
Number
#538
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #538 (commit e36c73ae, work commit 9dd87fe8) bumped Charmcraft to craft-parts 1.0.1, dropped the stage-package apt refresh, and cut regression test time from 1:30 to 0:37. Fixes #526, released in Charmcraft 1.3.0 via PR #548.

Resolution: closed resolved

Reason: PR #538 was merged into main as commit e36c73ae (commit 9dd87fe8 "requirements: update craft-parts to 1.0.1"), updating the pin to craft-parts 1.0.1 and removing stage package refreshes now that craft-parts uses the host apt cache. Reviewer @sergiusens confirmed on 2021-09-15 that it fixes #526, and the fix shipped in Charmcraft 1.3.0 (PR #548).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update dependencies to require Craft-parts 1.0.1 and remove refreshing of stage packages (Craft-parts now uses the host state for apt cache). Time comparison for non-parallel execution of regression tests: * with Craft-parts 1.0.0: `81.14user 15.46system 1:30.80elapsed` * with Craft-parts 1.0.1: `41.76user 3.97system 0:37.82elapsed` Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #538 (commit e36c73ae, work commit 9dd87fe8) bumped Charmcraft to craft-parts 1.0.1, dropped the stage-package apt refresh, and cut regression test time from 1:30 to 0:37. Fixes #526, released in Charmcraft 1.3.0 via PR #548.
stealth/space-bunny-alpha — closed resolved Merged #538 in commit e36c73ae, requiring craft-parts 1.0.1 and removing stage-package refreshes; it fixed #526 and shipped in Charmcraft 1.3.0.
stealth/space-bunny-alpha — closed resolved Merged PR #538 (commit e36c73ae) upgraded Charmcraft to craft-parts 1.0.1, removed stage-package refreshes, and fixed parallel destructive builds.
qwen/qwen3.6-35b-a3b — — Merged update to craft-parts 1.0.1 that removes stage package refreshing. The change halves regression test execution time, resolves issue #526, and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to craft-parts 1.0.1, removing stage package refreshing to resolve performance regression #526. Test execution time reduced from 90 to 38 seconds.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: charmcraft#526 (confidence 92%)

    Issue #526 (destructive mode blocked parallel charm builds) is the bug this PR fixes; the PR comment states "This fixes #526".

  • Related To: charmcraft#548 (confidence 88%)

    Release PR for Charmcraft 1.3.0 that shipped the craft-parts 1.0.1 requirement and the #526 fix to users.

Related issues

Issue Project State Summary Similarity
#592 requirements: update craft-parts to 1.0.4 charmcraft merged Merged PR #592 updated Charmcraft's craft-parts dependency from 1.0.3 to 1.0.4; commit 361e6bcf was merged via 6f383549.
90%
#1599 chore(deps): update dependency craft-parts to v1.27.0 charmcraft merged Renovate PR updating charmcraft's craft-parts pin from ==1.26.2 to ==1.27.0 (2 files, +2/-2). Approved by 2 reviewers with no unresolved comments and merged to main via commit c6e5d545.
81%
#579 requirements: update craft-parts to 1.0.3 (CRAFT-577) charmcraft merged Merged into main via #579 (merge commit 8c928d83), updating craft-parts from 1.0.2 to 1.0.3 in two requirement files for CRAFT-577.
80%
#622 Release 1.4.0 (CRAFT-720) charmcraft merged Merged Charmcraft 1.4.0 (CRAFT-720) in PR #622 via release commit 92573973 and merge commit 0ed29db6.
80%
#1690 chore(deps): update dependency craft-parts to v1.31.0 charmcraft merged Renovate bumped the craft-parts pin from ==1.29.0 to ==1.31.0 in charmcraft (2 files, +2/-2). Merged to main via commit 3a26492c after 2 approvals.
80%
#1092 requirements: update craft-parts to 1.19.2 charmcraft merged Merged PR charmcraft#1092 via commit a0e82335, upgrading craft-parts to 1.19.2 so ignore lists work correctly for local sources.
79%
#1099 requirements: update craft-parts to 1.19.3 charmcraft merged Merged canonical/charmcraft#1099 (c97f01dd), upgrading craft-parts to 1.19.3 to correct plugin-property state during the planning phase.
79%
#4327 requirements: update craft-parts to 1.23.1 snapcraft merged Merged PR #4327 updated craft-parts to 1.23.1, fixing rebuilds that could set the version twice.
79%
#4083 requirements: update craft-parts to 1.19.0 snapcraft merged Merged PR #4083 (commit 0e2cf91be) bumped craft-parts to 1.19.0, adopting feature selection that makes the overlay step optional and improving dirty checks for plugin-specific property changes.
78%
#728 parts: update craft-parts and enable craftctl charmcraft merged Merged charmcraft#728 in commit 5bf8f083, upgrading craft-parts to 1.4.0 and enabling craftctl for overridden part scriptlets.
78%