← Back to issue list

requirements: update craft-parts to 1.19.0

View original Github issue

Metadata

Project
snapcraft
Number
#4083
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4083 (commit 0e2cf91be) bumped craft-parts to 1.19.0, adopting feature selection that makes the overlay step optional and improving dirty checks for plugin-specific property changes.

Resolution: closed resolved

Reason: The PR was approved by a maintainer and merged into main as commit 0e2cf91be ("requirements: update craft-parts to 1.19.0 (#4083)"), updating the pinned dependency and enabling/adjusting for craft-parts feature selection. Codecov reported 100% diff coverage with no test changes needed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Craft-parts 1.19.0 introduces feature selection, making the overlay step optional, and checks if plugin-specific properties changed when verifying if a part is dirty. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4083 (commit 0e2cf91be) bumped craft-parts to 1.19.0, adopting feature selection that makes the overlay step optional and improving dirty checks for plugin-specific property changes.
stealth/space-bunny-alpha — closed resolved Merged craft-parts 1.19.0 into Snapcraft, adding feature selection with optional overlays and improved plugin-property dirty checks (commit 0e2cf91be).
stealth/space-bunny-alpha — closed resolved Merged PR #4083 in commit 0e2cf91be, updating craft-parts to 1.19.0 for feature selection, optional overlays, and improved plugin-property dirty checks.
stealth/space-bunny-alpha — closed resolved Merged PR #4083 (commit 0e2cf91be) bumping craft-parts to 1.19.0, picking up feature selection with optional overlay step and more accurate plugin-property dirty checks.
stealth/space-bunny-alpha — closed resolved Merged PR #4083 as commit 0e2cf91be, updating craft-parts to 1.19.0 for feature selection, optional overlays, and more accurate plugin-property dirty checks.
stealth/space-bunny-alpha — closed resolved Merged PR #4083 (commit 0e2cf91be), updating craft-parts to 1.19.0 to support feature selection, make overlays optional, and improve dirty checking.
stealth/space-bunny-alpha — closed resolved Merged PR #4083 (commit 0e2cf91be), updating craft-parts to 1.19.0 to enable feature selection, optional overlay steps, and improved plugin-specific dirty checks.
qwen/qwen3.6-35b-a3b — — Merged update to craft-parts 1.19.0, enabling optional overlay steps, feature selection, and improved dirty checking. Approved by reviewer, passed CI, and merged into main.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to craft-parts 1.19.0, enabling feature selection, optional overlay steps, and improved dirty checking. Codecov confirmed 100% diff coverage with no overall coverage change.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4092 (confidence 35%)

    Nearby follow-up work on plugin checks shortly after the craft-parts 1.19 upgrade.

Related issues

Issue Project State Summary Similarity
#245 requirements: update craft-parts to 1.19.3 rockcraft merged Merged PR #245 as commit 2e0eddfb, updating requirements to craft-parts 1.19.3 to correct plugin-properties state during planning.
89%
#218 requirements: update craft-parts to 1.19.0 rockcraft merged Merged as commit 3c9fc942: bumped craft-parts to 1.19.0, enabled overlays (now required by that release), and updated OS release verification in tests after Craft Parts dropped Ubuntu codenames.
88%
#1099 requirements: update craft-parts to 1.19.3 charmcraft merged Merged canonical/charmcraft#1099 (c97f01dd), upgrading craft-parts to 1.19.3 to correct plugin-property state during the planning phase.
86%
#4120 requirements: update craft-parts to 1.19.3 snapcraft merged Merged PR #4120 as b4fa73795, updating Snapcraft to craft-parts 1.19.3 for the planning-phase plugin-properties state fix.
86%
#4168 requirements: update craft-parts to 1.19.4 snapcraft closed Update to craft-parts 1.19.4 was closed unmerged as superseded by #4173, which updated to 1.19.5 in commit f0f5fca3a.
86%
#4173 requirements: update craft-parts to 1.19.5 snapcraft merged Merged as f0f5fca3a, updating craft-parts to 1.19.5 to fix subdir handling in pull and build steps.
84%
#4207 requirements: update craft-parts to 1.19.6 snapcraft merged Merged #4207 as d7a504899, updating craft-parts to 1.19.6 to revert subdirectory handling changes in pull and build steps.
84%
#191 requirements: update craft-parts to 1.18.1 rockcraft merged Merged PR #191 as commit 6fae4cbf, updating craft-parts to 1.18.1 to fix ignored file patterns in local-source processing.
84%
#4305 requirements: update craft-parts to 1.19.7 snapcraft merged Merged #4305 into hotfix/7.5, updating craft-parts to 1.19.7 so rebuilds no longer set the version twice.
84%
#4183 requirements: update craft-parts to 1.21.0 snapcraft merged Merged PR #4183 updated Snapcraft's craft-parts requirement to 1.21.0 in commit 8f6a8b353, aligning it with new base and overlay package callbacks.
84%