build: ignore venv in project source (CRAFT-591)
Metadata
Current evaluation
Merged in charmcraft#584 via 6d5c2595; ef1f6fdd moved venv into the default Juju ignore patterns, so charm packing no longer requires a manual .jujuignore entry.
Resolution: closed resolved
Reason: PR #584 was approved and merged as commit 6d5c2595. Follow-up commit ef1f6fdd added venv to the default jujuignore behavior, resolving CRAFT-591.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If a project source contains an entry called `venv`, it's mandatory
to ignore it to be able to pack the charm. Instead of requiring
`.jujuignore` to list it, add it to the list of ignored local source
entries when creating the parts lifecycle.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in charmcraft#584 via 6d5c2595; ef1f6fdd moved venv into the default Juju ignore patterns, so charm packing no longer requires a manual .jujuignore entry. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged CRAFT-591 to ignore venv entries in project source during parts lifecycle creation, allowing charm packing without manually listing venv in .jujuignore. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds venv to ignored local source entries to prevent charm packing failures. Reviewer suggested using default_juju_ignore instead, and the author agreed to implement that change in a follow-up patch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added venv to ignored local source entries to fix charm packing. Reviewer suggested using default_juju_ignore instead. Author agreed to refactor the implementation to default_jujuignore.py in a follow-up patch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #112 Include everything but what is explicity ignored to Juju. | charmcraft | merged | Merged PR #112 as 9f241a8a, changing Charmcraft to include all project files for Juju except those excluded by default or .jujuignore rules. |