Include everything but what is explicity ignored to Juju.
Metadata
Current evaluation
Merged PR #112 as 9f241a8a, changing Charmcraft to include all project files for Juju except those excluded by default or .jujuignore rules.
Resolution: closed resolved
Reason: PR #112 was merged as commit 9f241a8a, implementing include-all-except-ignored behavior. Its prerequisite, PR #99, previously merged as b9c265a3 to support extending Juju's default ignore patterns.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Setting it to "Draft" because there are some remaining FIXMEs, for which I'm waiting for PR #99 to land.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #112 as 9f241a8a, changing Charmcraft to include all project files for Juju except those excluded by default or .jujuignore rules. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #112 via commit 9f241a8a, making charm packaging include all project files except Juju defaults and explicit .jujuignore exclusions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the Juju file-inclusion change, replacing the prior explicit include behavior with inclusion of all files except those explicitly ignored. PR #99 was cited as a related prerequisite, but no follow-up details are provided. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two reviewers approved. Updates Juju configuration to include all items except those explicitly ignored. Changes add 304 lines and remove 222 across two files, resolving pending FIXMEs and finalizing the implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to include all files except those explicitly ignored for Juju. Initially drafted pending PR #99, the change was finalized and merged after resolving dependencies. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#99
(confidence 99%)
Prerequisite PR cited by #112; merged as b9c265a3 and added extendable Juju ignore patterns.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #39 Include all project files (whatever is present there) | charmcraft | closed | Resolved by packaging all project files except Juju-style ignores. PR #99 (b9c265a3) added extensible .jujuignore support; PR #118 (ea36c9bd) prepared the all-files build behavior. | |
| #108 Give charmers a mechanism to specify additional files to be included in the build charms. | charmcraft | closed | Closed as a duplicate of #39; Juju-compatible ignore handling in #99 and all-files packaging groundwork in #118 replaced the static include list. | |
| #584 build: ignore venv in project source (CRAFT-591) | charmcraft | merged | Merged in charmcraft#584 via 6d5c2595; ef1f6fdd moved venv into the default Juju ignore patterns, so charm packing no longer requires a manual .jujuignore entry. |