← Back to issue list

Use a progress bar in the three upload points Charmcraft has.

View original Github issue

Metadata

Project
charmcraft
Number
#586
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

PR #586 merged (merge commit e50353c8, squashed as ab0603b6) by facundobatista, adding progress bars to Charmcraft's three store upload points, +102/-50 across 5 files.

Resolution: closed resolved

Reason: The PR was merged into master as commit e50353c8 with the change squashed as ab0603b6, adding a progress bar to the three upload flows handled in charmcraft/_store.py. It was approved by one reviewer with no unresolved comments, so the work landed as intended.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #586 merged (merge commit e50353c8, squashed as ab0603b6) by facundobatista, adding progress bars to Charmcraft's three store upload points, +102/-50 across 5 files.
stealth/space-bunny-alpha — closed resolved Merged as canonical/charmcraft#586 (e50353c8), adding progress bars to Charmcraft's three upload points.
qwen/qwen3.6-35b-a3b — — Merged after single reviewer approval. Implemented progress bars across Charmcraft's three upload endpoints, modifying five files with 102 additions and 50 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes adding progress bars to Charmcraft's three upload points. Maintainer facundobatista submitted the update, which was accepted and integrated without additional review comments.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#2342 (confidence 25%)

    Low-confidence: the charmcraft/_store.py module touched by this PR no longer exists in the current tree due to later refactors of the upload code, but no direct successor PR was identified.

Related issues

Issue Project State Summary Similarity
#381 Replace "print"s for proper progress calls when we have the "messages to the user" lib integrated charmcraft closed Prints in the store registry/client upload paths were replaced with craft-cli progress reporting; PR #586 (branch show-progress-properly, merge e50353c8, squash ab0603b6) added progress bars to Charmcraft's three upload points.
73%
#611 `charmcraft upload-resource` Uploading percentage with a wrong format charmcraft closed Malformed upload-resource percentage output was replaced with progress bars in canonical/charmcraft#586, merged as e50353c8 (implementation commit ab0603b6).
71%