Replace "print"s for proper progress calls when we have the "messages to the user" lib integrated
Metadata
Current evaluation
Prints in the store registry/client upload paths were replaced with craft-cli progress reporting; PR #586 (branch show-progress-properly, merge e50353c8, squash ab0603b6) added progress bars to Charmcraft's three upload points.
Resolution: closed resolved
Reason: PR #586 "Use a progress bar in the three upload points Charmcraft has." was merged by the author (facundobatista) as merge commit e50353c8, squashed as ab0603b6, which touches charmcraft/commands/store/client.py (where the issue's listed prints lived) and swaps the bare print() calls for craft-cli emit/progress calls.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Prints in the store registry/client upload paths were replaced with craft-cli progress reporting; PR #586 (branch show-progress-properly, merge e50353c8, squash ab0603b6) added progress bars to Charmcraft's three upload points. | |
| stealth/space-bunny-alpha | — | closed resolved | Replaced direct prints with proper progress reporting across the three Charmcraft upload paths, merged in PR #586. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution or linked pull requests. The request to replace print statements with progress calls was abandoned or superseded by subsequent refactoring after the user messaging library was integrated. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The request to replace print statements with progress calls in registry.py and client.py was abandoned. No comments or PRs were linked, leaving the task pending the referenced library integration. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation or discussion, indicating the task was abandoned or superseded. Replacing print statements with progress calls in registry.py and client.py received no pull requests or follow-up activity. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without implementation. The request to replace print statements with proper progress calls in registry.py and client.py was abandoned after the referenced messages library was never integrated. No fixes were submitted. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#586
(confidence 95%)
Merged PR adding progress reporting to the three store upload points that previously used print(), matching the issue's scope.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #586 Use a progress bar in the three upload points Charmcraft has. | charmcraft | merged | PR #586 merged (merge commit e50353c8, squashed as ab0603b6) by facundobatista, adding progress bars to Charmcraft's three store upload points, +102/-50 across 5 files. | |
| #96 Improved the _Progresser and how it's used (CRAFT-1139). | craft-cli | merged | Merged into main as commit 90b3c8e via PR #96, improving _Progresser with timestamps, start/end markers, and optional timestamped Printer progress bars for CRAFT-1139. |