Forbid login/logout when using alternate auth (CRAFT-646).
Metadata
Current evaluation
Merged PR #597 (CRAFT-646) into main via commit fb8a160b, merge 13a79cf9: charmcraft's store client now raises CraftError to forbid `login`/`logout` when alternate auth is set via the env var. Follow-up PR #599 improved retry UX.
Resolution: closed resolved
Reason: PR #597 was approved and merged into main; commit fb8a160b overrides StoreClient.login/logout in charmcraft/store/client.py to raise CraftError when const.ALTERNATE_AUTH_ENV_VAR is set, with tests test_alternate_auth_login_forbidden/logout_forbidden added.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #597 (CRAFT-646) into main via commit fb8a160b, merge 13a79cf9: charmcraft's store client now raises CraftError to forbid `login`/`logout` when alternate auth is set via the env var. Follow-up PR #599 improved retry UX. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the CRAFT-646 change forbidding login/logout commands when alternate authentication is configured. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged CRAFT-646 to forbid login/logout when alternate authentication is used; the approved PR added 44 lines across two files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the CRAFT-646 change to prohibit login/logout when alternate authentication is configured; no PR number or commit SHA is available. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval. The update disables login and logout functionality when alternate authentication is configured, addressing CRAFT-646. The commit introduces 44 lines across two modified files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer facundobatista, this change prevents login and logout operations when alternate authentication is enabled, resolving CRAFT-646. No additional discussion or revisions were required. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#599
(confidence 80%)
Follow-up 'Better UX when retrying store ops if alternate auth is used' (commit 91d3386a), extending the same alternate-auth handling.
-
Superseded By:
canonical/charmcraft#2760
(confidence 45%)
Much later commit 9279665a migrated from the alternate-auth (Candid) mechanism to Ubuntu One auth, superseding this env-var-based behaviour.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #599 Better UX when retrying store ops if alternate auth is used (CRAFT-653). | charmcraft | merged | Merged in canonical/charmcraft#599 (c6ec9c0d), improving store retries with alternate auth by prompting users to regenerate invalid credentials instead of re-login. | |
| #598 Formalize and improve default login restrictions at store-api level (CRAFT-640). | charmcraft | closed | Closed unmerged after the API changed; canonical/charmcraft#603 replaced it with restrictive login options for CRAFT-640 and was merged via 65699808. | |
| #916 (charmhub) Provide a better error to the user on a login attempt when already having credentials (CRAFT-1269) | charmcraft | merged | Merged PR #916 in commit 3b54c459, improving the double-login error to explain that stored credentials may be invalid and recommend logging out; fixes #833. |