← Back to issue list

Formalize and improve default login restrictions at store-api level (CRAFT-640).

View original Github issue

Metadata

Project
charmcraft
Number
#598
Type
pull request
State
closed
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after the API changed; canonical/charmcraft#603 replaced it with restrictive login options for CRAFT-640 and was merged via 65699808.

Resolution: closed superseded

Reason: The author closed the proposal after noting the API change and promised a replacement including the CLI layer. canonical/charmcraft#603 implemented that replacement and merged as 65699808.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Note this is still unused until `craft-store` grows support for it.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after the API changed; canonical/charmcraft#603 replaced it with restrictive login options for CRAFT-640 and was merged via 65699808.
stealth/space-bunny-alpha — closed superseded Closed unmerged after the API changed; replacement PR canonical/charmcraft#603 added restrictive login options and was merged for CRAFT-640.
qwen/qwen3.6-35b-a3b — — Closed without merging. The author noted the API changed and planned to submit a new PR including the CLI layer, superseding this work on formalizing default store-api login restrictions.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. Changes remain unused until craft-store adds support. Due to API changes, the maintainer plans to submit a new PR including the CLI layer, effectively superseding this request.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#603 (confidence 100%)

    Replacement PR adding restrictive login options for CRAFT-640; merged with implementation commit f5552466.

Related issues

Issue Project State Summary Similarity
#603 Added restrictive options to login command (CRAFT-640). charmcraft merged Merged #603 (65699808; implementation f5552466), adding restrictive options to the login command for CRAFT-640.
77%
#597 Forbid login/logout when using alternate auth (CRAFT-646). charmcraft merged Merged PR #597 (CRAFT-646) into main via commit fb8a160b, merge 13a79cf9: charmcraft's store client now raises CraftError to forbid `login`/`logout` when alternate auth is set via the env var. Follow-up PR #599 improved retry UX.
72%