← Back to issue list

craft store: update to 2.0.0 (CRAFT-773)

View original Github issue

Metadata

Project
charmcraft
Number
#667
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged craft store update to 2.0.0. Changes include updated StoreClient initialization, renaming NotLoggedIn to CredentialsUnavailable, improved keyring handling, and adjusted relogin logic. Approved by one reviewer, passed CI, and merged by maintainer sergiusens.

Suggested action:

No scores available.

Issue body

- updated StoreClient init to use new parameters (without making use of them yet) - s/NotLoggedIn/CredentialsUnavailable/ - better support for missing Keyring scenarios - adapted the relogin scenario to consider CredentialsAlreadyAvailable Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged craft store update to 2.0.0. Changes include updated StoreClient initialization, renaming NotLoggedIn to CredentialsUnavailable, improved keyring handling, and adjusted relogin logic. Approved by one reviewer, passed CI, and merged by maintainer sergiusens.
qwen3.6-35b-a3b-mtp-q6 Merged update to craft store client 2.0.0. Changes include updating StoreClient initialization, renaming NotLoggedIn to CredentialsUnavailable, improving keyring error handling, and adjusting relogin logic. Resolves CRAFT-773.
qwen3.6-35b-a3b-mtp-q6 Merged craft store 2.0.0 update. Changes include updated StoreClient initialization, renamed NotLoggedIn to CredentialsUnavailable, improved missing Keyring support, and adapted relogin logic for CredentialsAlreadyAvailable scenarios.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3945 requirements: craft-store 2.3.0 for new credentials snapcraft merged Merged a dependency update bumping craft-store to 2.3.0 for new credentials support. Approved by a maintainer, passed CI and tests, and merged into main with no coverage impact.
80%
#671 snap: update craft-store to 2.0.1 charmcraft merged The craft-store update to 2.0.1 was successfully merged after receiving reviewer approval and passing CI checks. The minor two-file change was integrated without further modifications.
80%
#4455 build(deps): bump craft-store to 2.5.0 snapcraft merged Merged update bumping craft-store to 2.5.0, enabling headless systems to fallback to a file-based keyring backend. Approved by two reviewers, passed CI, and successfully integrated.
77%
#1388 build(deps): bump craft-store to 2.5.0 charmcraft merged Merged dependency bump to craft-store 2.5.0, resolving issue #719. Enables headless systems to fallback to a file-based keyring backend. Approved by two reviewers and passed CI.
75%
#5536 fix(store): catch credential decoding errors snapcraft merged Merged fix that catches invalid SNAPCRAFT_STORE_CREDENTIALS decoding errors, replacing internal crashes with user-friendly messages. Updated craft-store dependency to 3.2.2 and resolved issue #5161.
71%
#3692 legacy storeapi: use craft-store snapcraft merged Merged PR replaces the legacy storeapi HTTP client with craft-store, removes obsolete tests and logout calls, and adapts the codebase to craft-store API changes. Approved and passed CI.
71%
#5084 build(deps): bump craft-store to 3.0.2 snapcraft merged Merged dependency update bumping craft-store to 3.0.2. Approved by reviewers and passed CI. Resolves core20 spread test failures and fixes issue #5077 by incorporating changes from #5061.
70%
#44 store client: use netloc to reference keyring location (CRAFT-799) craft-store merged Merged update to store client using netloc for keyring location references and passing the host parameter to Auth. Removed unused attribute. Existing logins are forgotten as a known side effect. Approved by two reviewers and passed CI.
70%