← Back to issue list

craft store: update to 2.0.0 (CRAFT-773)

View original Github issue

Metadata

Project
charmcraft
Number
#667
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #667 by sergiusens bumped charmcraft to craft-store 2.0.0 (CRAFT-773, commit 7d893cdc): new StoreClient init params, NotLoggedIn -> CredentialsUnavailable rename, better missing-keyring handling.

Resolution: closed resolved

Reason: PR #667 was merged into the mainline with one approving review and no unresolved comments, landing as commit 7d893cdc ("craft store: update to 2.0.0"). The change persisted: charmcraft/services/store.py and tests/commands/test_store_api.py at HEAD still reference craft_store.errors.CredentialsUnavailable, confirming the rename shipped.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- updated StoreClient init to use new parameters (without making use of them yet) - s/NotLoggedIn/CredentialsUnavailable/ - better support for missing Keyring scenarios - adapted the relogin scenario to consider CredentialsAlreadyAvailable Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #667 by sergiusens bumped charmcraft to craft-store 2.0.0 (CRAFT-773, commit 7d893cdc): new StoreClient init params, NotLoggedIn -> CredentialsUnavailable rename, better missing-keyring handling.
stealth/space-bunny-alpha — closed resolved Merged PR #667 upgraded craft-store to 2.0.0, adapting StoreClient initialization, credential errors, missing-keyring handling, and relogin behavior.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#667 (CRAFT-773), updating craft-store to 2.0.0, StoreClient initialization, credential exceptions, and keyring handling.
qwen/qwen3.6-35b-a3b — — Merged craft store update to 2.0.0. Changes include updated StoreClient initialization, renaming NotLoggedIn to CredentialsUnavailable, improved keyring handling, and adjusted relogin logic. Approved by one reviewer, passed CI, and merged by maintainer sergiusens.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to craft store client 2.0.0. Changes include updating StoreClient initialization, renaming NotLoggedIn to CredentialsUnavailable, improving keyring error handling, and adjusting relogin logic. Resolves CRAFT-773.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-store#44 (confidence 60%)

    Follow-on craft-store change (CRAFT-799) adjusting keyring location to use netloc, related to the keyring-handling work introduced here.

  • Related To: canonical/charmcraft#1388 (confidence 40%)

    Later commit 70066d49 bumps craft-store further to 2.5.0, continuing the same dependency line upgraded by this PR.

Related issues

Issue Project State Summary Similarity
#1388 build(deps): bump craft-store to 2.5.0 charmcraft merged Merged PR #1388 as commit 70066d49, upgrading craft-store to 2.5.0 to add a file-based keyring fallback on headless systems and fix #719.
77%
#4455 build(deps): bump craft-store to 2.5.0 snapcraft merged Merged PR #4455 (commit 9b5c2f4cf) bumped craft-store to 2.5.0, enabling headless systems to use a file-based keyring fallback for login.
77%
#3945 requirements: craft-store 2.3.0 for new credentials snapcraft merged Merged #3945 into main as d33d61753, bumping craft-store to 2.3.0 to support the new credentials format.
75%
#48 release: 2.0.1 craft-store merged Merged craft-store 2.0.1 via PR #48; merge commit fb75d74 brought in release commit 53f880d.
74%
#63 release: 2.2.0 craft-store merged Craft Store 2.2.0 was released by merging approved PR #63; the release landed as commit bf82766.
74%
#67 release 2.2.1 craft-store merged Merged craft-store 2.2.1 in PR #67 via commit ee98080.
73%
#24 release: 1.1.0 (CRAFT-645) craft-store merged Merged craft-store 1.1.0 for CRAFT-645 via PR #24 in merge commit 562b51f.
72%
#42 release: 2.0.0 (CRAFT-772) craft-store merged Merged #42 to release craft-store 2.0.0 for CRAFT-772; release commit 1b34846 and merge commit cb6ccd9 finalized the two-file version bump.
72%
#10 release: 0.0.1.dev2 craft-store merged Merged release PR #10, publishing craft-store 0.0.1.dev2 via release commit 2145f6a (merge commit c60cdc8).
72%
#671 snap: update craft-store to 2.0.1 charmcraft merged Merged into main as 26b067a7 (merge 23612dab), bumping craft-store from 2.0.0 to 2.0.1 in the snapcraft.yaml and requirements files (+2/-2 lines).
72%