← Back to issue list

errors: catch all CraftStoreErrors (CRAFT-813)

View original Github issue

Metadata

Project
charmcraft
Number
#670
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged. Catches all CraftStoreErrors during craft_store library initialization. Approved by one reviewer with passing CI checks across 5 files (+35/-30).

Suggested action: —

No scores available.

Issue body

Catch all CraftStoreErrors while initializing the craft_store library.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. Catches all CraftStoreErrors during craft_store library initialization. Approved by one reviewer with passing CI checks across 5 files (+35/-30).
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to catch all CraftStoreErrors during craft_store library initialization, resolving CRAFT-813.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to catch all CraftStoreErrors during craft_store library initialization, resolving CRAFT-813.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3466 store: do not unnecessarily catch/rewrite exceptions snapcraft merged Merged into master. Removes unnecessary exception handling in store module login functions to surface original errors for debugging. Drops unused error constants and updates tests. Approved with passing CI and 100% diff coverage.
73%
#2084 fix(store): better error message with fetch-lib charmcraft merged Merged updates that improve error messaging for fetch-lib in the store component. Approved by two reviewers, passed CI, and resolves issue #1721 and CRAFT-3352 across two files.
72%
#12 errors: expose the StoreServerError cause from the returned json (CRAFT-582) craft-store merged Exposed the StoreServerError cause from returned JSON. Merged after approval and passing CI checks. Modified three files (+135/-9 lines) to resolve CRAFT-582.
72%
#591 Revisited all error usage to adapt to new craft-cli context. charmcraft merged Merged after approval and CI. Updated error handling for craft-cli by using from err for subprocess errors, adding details attributes, adjusting Store return codes, and transforming StoreServerError. Changed 8 files.
70%