← Back to issue list

errors: catch the correct JSONDecodeError

View original Github issue

Metadata

Project
craft-store
Number
#61
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in craft-store#61 via commit e2ce4b5, correcting JSONDecodeError handling for CRAFT-1238 across three files.

Resolution: closed resolved

Reason: The approved pull request was merged into the project. Commit e2ce4b5 records the change that catches the correct JSONDecodeError for CRAFT-1238.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1238

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in craft-store#61 via commit e2ce4b5, correcting JSONDecodeError handling for CRAFT-1238 across three files.
stealth/space-bunny-alpha — closed resolved Merged the approved 3-file fix for CRAFT-1238, changing error handling to catch the correct JSONDecodeError.
qwen/qwen3.6-35b-a3b — — Merged, resolving CRAFT-1238 by correcting JSONDecodeError handling to catch the proper exception. Approved by one reviewer, passed CI, and modified three files with a three-line change.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#670 errors: catch all CraftStoreErrors (CRAFT-813) charmcraft merged Merged PR #670 broadened craft_store initialization error handling to catch all CraftStoreErrors; implementation fe3215e3 landed via merge commit 677b399f.
76%
#12 errors: expose the StoreServerError cause from the returned json (CRAFT-582) craft-store merged Merged canonical/craft-store#12, exposing StoreServerError causes from returned JSON and adding expanded error handling and tests.
74%