Enforced DN03: the 'bases' is now mandatory for charms in the config (CRAFT-785).
Metadata
Current evaluation
Merged PR canonical/charmcraft#791 (9c52a73a), enforcing DN03 so charm configs require bases and updating affected tests; fixes #655.
Resolution: closed resolved
Reason: PR #791 was approved and merged via commit 9c52a73a. Its implementation commit d02c3297 made bases mandatory for charm configuration and resolved issue #655.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Of course this not only led to the change in the code, but to a lot of
config not-bases-related tests where I had to add 'bases'. Note that in
a lot of cases I just changed the 'type' to 'bundle' (where being a
charm was not relevant to the test) to minimize the amount of changes.
Fixes #655.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/charmcraft#791 (9c52a73a), enforcing DN03 so charm configs require bases and updating affected tests; fixes #655. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged Charmcraft PR #791, enforcing mandatory bases for charm configs under DN03 and updating tests; fixes charmcraft#655 (merge 9c52a73a). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #791 enforced DN03 by making bases mandatory for charm configurations, updated affected tests, and fixed charmcraft#655. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged charmcraft PR #791, enforcing DN03 by requiring bases for charms and updating affected tests; fixes charmcraft#655. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Enforced mandatory 'bases' field in charm configuration per DN03 (CRAFT-785), resolving #655. Updated config and tests to include bases or switched test types to bundle. Approved by one reviewer and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enforced 'bases' as mandatory for charms in configuration per DN03 and CRAFT-785, resolving issue #655. Test suites were updated accordingly, with several converted to bundle type to minimize modifications. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#655
(confidence 100%)
PR #791 explicitly fixes the closed DN03 bases-requirement issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #655 Enforce deprecation DN03: Bases configuration is now required | charmcraft | closed | DN03 was enforced by requiring charm bases in configuration; the change was merged in canonical/charmcraft#791 via commit 9c52a73a. | |
| #383 commands/build: charm file name format support for bases (CRAFT-66) | charmcraft | merged | Merged PR #383 (commit 951f6aaa; merge 1c839909) added bases-aware charm filename formatting and tests, retaining the legacy runtime path pending default-bases configuration. | |
| #654 Enforce deprecation DN02: A charmcraft.yaml configuration file is now required | charmcraft | closed | DN02 was enforced by merged PR #680 (7df649fd), making charmcraft.yaml mandatory for builds and requiring its type key. | |
| #677 Enforce DN01: do not support charmhub attributes with underscores anymore (CRAFT-783). | charmcraft | merged | Merged PR #677 in f6451e6f, removing support for Charmhub attribute names containing underscores and enforcing DN01. | |
| #414 config/build: set default bases configuration with DNs (CRAFT-265, CRAFT-266) | charmcraft | merged | Merged charmcraft#414 in commit 3bfa45c0, defaulting builds to Ubuntu 20.04 for the host architecture, ending legacy builds, and adding DN02/DN03 deprecation notices. | |
| #215 fix(charm): accept redundant multi-base charms | craft-platforms | merged | Merged PR #215 as commit 4879309, allowing redundant multi-base charms when they produce equivalent valid build plans and addressing canonical/charmcraft#2620. | |
| #1030 login, names and register should not fail with "The field 'bases' is mandatory when type=charm" | charmcraft | closed | Fixed by merged PR #1035 (commit 91a5f553): login, register, and names no longer fail when run in charm source directories without a bases field. |