← Back to issue list

Enforced DN03: the 'bases' is now mandatory for charms in the config (CRAFT-785).

View original Github issue

Metadata

Project
charmcraft
Number
#791
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged. Enforced mandatory 'bases' field in charm configuration per DN03 (CRAFT-785), resolving #655. Updated config and tests to include bases or switched test types to bundle. Approved by one reviewer and passed CI.

Suggested action:

No scores available.

Issue body

Of course this not only led to the change in the code, but to a lot of config not-bases-related tests where I had to add 'bases'. Note that in a lot of cases I just changed the 'type' to 'bundle' (where being a charm was not relevant to the test) to minimize the amount of changes. Fixes #655.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Enforced mandatory 'bases' field in charm configuration per DN03 (CRAFT-785), resolving #655. Updated config and tests to include bases or switched test types to bundle. Approved by one reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged. Enforced 'bases' as mandatory for charms in configuration per DN03 and CRAFT-785, resolving issue #655. Test suites were updated accordingly, with several converted to bundle type to minimize modifications.
qwen3.6-35b-a3b-mtp-q6 Merged. Enforced DN03 by making 'bases' mandatory for charms in configuration. Updated related tests and converted several to bundle type to minimize changes. Resolves #655.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#383 commands/build: charm file name format support for bases (CRAFT-66) charmcraft merged Merged following approval by three reviewers. Introduces charm file name format support for bases configuration, preserving the existing format as a legacy runtime path. Includes corresponding tests. (+98/-1 lines, 2 files changed)
73%
#414 config/build: set default bases configuration with DNs (CRAFT-265, CRAFT-266) charmcraft merged Merged after two reviewer approvals. Updates default bases configuration to Ubuntu 20.04, ending legacy builds. Introduces deprecation notices DN02 and DN03 for missing or outdated charmcraft.yaml files and adds a test fixture to reset deprecation state.
73%
#411 build: pack charm in provided environment when using bases (CRAFT-313) charmcraft merged Merged implementation for packing charms in provided environments per bases configuration (CRAFT-313). Approved by two reviewers, modifying two files (+175/-30). Future work will add verbose and quiet mode flag support.
71%