← Back to issue list

Removed the long time deprecated 'build' command (CRAFT-1109).

View original Github issue

Metadata

Project
charmcraft
Number
#798
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #798 (commit 2da73fb8) removed the long-deprecated build command; pack absorbed bases_index validation and redundant validator arguments.

Resolution: closed resolved

Reason: PR #798 was approved and merged as merge commit 2da73fb8, with implementation commit 20b45e92. It removed the deprecated build command and simplified its validator while preserving relevant validation in pack.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The Validator, also used from `pack`, no longer makes sense: - bases_index: moved this control to the Pack command. - `from`: this was filled with the result of --project-dir, which already verified that the directory existed - `destructive_mode`, `debug`, `shell`, `shell_after` and `force`: just converted an already bool to bool Left for next PR: move the `Builder` class and helper function/constants to the `pack.py` file (which would be a huge diff, specially because of tests, but without semantic changes).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #798 (commit 2da73fb8) removed the long-deprecated build command; pack absorbed bases_index validation and redundant validator arguments.
stealth/space-bunny-alpha — closed resolved Merged PR #798 removed the deprecated build command, moved bases_index validation to Pack, and simplified redundant boolean arguments; Builder migration remains follow-up work.
qwen/qwen3.6-35b-a3b — — Merged removal of the deprecated 'build' command. Validator controls moved to Pack and booleans simplified. Changed 7 files (+92/-374). Approved and passed CI. Builder migration deferred to a follow-up PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the deprecated build command. Validator logic was refactored, moving bases_index control to the Pack command and removing unused fields. Bool conversions simplified. Builder class migration deferred to a subsequent PR.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#739 Hide the 'build' command and make 'pack' the common one (CRAFT-938). charmcraft merged Merged PR #739 as commit 1a461c39, hiding deprecated build from help and promoting pack as the standard command; it fixes #720 (CRAFT-938).
77%
#664 Deprecate the `build` command charmcraft closed Charmcraft 1.5 deprecated `build` through merged PR #683 (commit ae230370), adding a notice directing users to `pack`.
72%
#411 build: pack charm in provided environment when using bases (CRAFT-313) charmcraft merged Merged PR #411 (CRAFT-313) to pack each viable bases configuration in its provided build environment; merge commit 523c6fb0.
71%
#892 (internal) Remove CharmcraftBuilddBaseConfiguration and use BuilddBase directly (CRAFT-1278, CRAFT-1356). charmcraft merged Merged #892, removing CharmcraftBuilddBaseConfiguration and using BuilddBase directly; commit 57313bc3 was merged as 834a4fd4.
70%
#793 Removed the --entrypoint option for build and pack commands (CRAFT-786). charmcraft merged Merged PR #793 via aa51786b (change 3b9937a7), removing --entrypoint from build and pack and fixing #656.
70%
#797 Removed the --requirements option for build and pack commands (CRAFT-787). charmcraft merged Merged #797 (commit 63d57d8c), removing the legacy --requirements option from build and pack and fixing #657.
70%