← Back to issue list

providers: delete instances via Executor object

View original Github issue

Metadata

Project
charmcraft
Number
#835
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #835 (commit 4f65ca35) switched provider cleanup to delete each instance through craft-providers’ Executor, preventing failures after upstream instance renaming.

Resolution: closed resolved

Reason: PR #835 was merged as commit 4f65ca35, with implementation in 545cfc15. It replaced low-level deletion with per-instance Executor deletion, correctly handling renamed instances.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Previously, `charmcraft` bypassed `craft-providers` `Executor` object to delete instances. This low-level delete call causes issues when `craft-providers` modifies the name of the actual instance (which occurs [here](https://github.com/canonical/craft-providers/pull/134)). Now, a build plan is created and instances are deleted one-by-one via the `Executor` object. (CRAFT-1250)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #835 (commit 4f65ca35) switched provider cleanup to delete each instance through craft-providers’ Executor, preventing failures after upstream instance renaming.
stealth/space-bunny-alpha — closed resolved Merged PR #835 (4f65ca35) replaced low-level instance deletion with per-instance deletion through the craft-providers Executor, avoiding failures after instance renaming.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI. Replaced direct instance deletion with the Executor object to prevent failures when instance names are modified. Updated 9 files (+332/-348 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced low-level instance deletion with the craft-providers Executor object to prevent failures when instance names are modified. Build plans now handle one-by-one cleanup.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/craft-providers#134 (confidence 98%)

    The upstream change that can rename actual provider instances exposed the previous deletion approach.

Related issues

Issue Project State Summary Similarity
#3875 providers: delete instances via Executor object snapcraft merged Merged PR #3875 as c1cc43cb8 into hotfix/7.1.2, switching instance cleanup to Executor so craft-providers-normalized names are handled correctly (CRAFT-1249).
90%