providers: delete instances via Executor object
Metadata
Current evaluation
Merged PR #3875 as c1cc43cb8 into hotfix/7.1.2, switching instance cleanup to Executor so craft-providers-normalized names are handled correctly (CRAFT-1249).
Resolution: closed resolved
Reason: PR #3875 was merged as commit c1cc43cb8. It replaced low-level instance deletion with Executor-based deletion, fixing cleanup when craft-providers changes the actual instance name.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Previously, `snapcraft` bypassed `craft-providers` `Executor` object to delete instances.
This low-level delete call causes issues when `craft-providers` modifies the name of the actual instance. (which happens [here](https://github.com/canonical/craft-providers/pull/134))
Instances are now deleted via the `Executor` object.
(CRAFT-1249)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3875 as c1cc43cb8 into hotfix/7.1.2, switching instance cleanup to Executor so craft-providers-normalized names are handled correctly (CRAFT-1249). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as c1cc43cb8 into hotfix/7.1.2: snapcraft now deletes provider instances through craft-providers' Executor object instead of a low-level delete, fixing instance-name normalization issues (CRAFT-1249). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in c1cc43cb8 (#3875) for hotfix/7.1.2, routing instance deletion through Executor to handle craft-providers’ normalized instance names (CRAFT-1249). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into hotfix/7.1.2. Routes instance deletion through the Executor object to resolve compatibility issues when craft-providers modifies instance names. Approved and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into hotfix/7.1.2. Instance deletion now uses the craft-providers Executor object, fixing failures when the provider renames instances. Code coverage increased by 0.76%. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/craft-providers#134
(confidence 98%)
Its instance-name normalization exposed Snapcraft's bypassing of the Executor deletion path.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #835 providers: delete instances via Executor object | charmcraft | merged | Merged PR #835 (commit 4f65ca35) switched provider cleanup to delete each instance through craft-providers’ Executor, preventing failures after upstream instance renaming. |