← Back to issue list

Isolated charm_builder.py as a generic plugin script (CRAFT-1032).

View original Github issue

Metadata

Project
charmcraft
Number
#865
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 56242113, isolating charm_builder.py as a standalone plugin with stdout output and RuntimeError, fixing #750.

Resolution: closed resolved

Reason: PR #865 was merged into the main branch as commit 56242113. It completed the conversion of charm_builder.py to a generic standalone plugin, replaced CraftError usage with RuntimeError, and explicitly fixed issue #750.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This will stop its execution from showing some weirdness in the logs and improve the general structure of the code (stop mixing code run from the plugin with the rest of Charmcraft). After a long talk with Claudio yesterday we decided to convert all outputs to plain prints to stdout, again, as a regular plugin script. Also converted the CraftError exceptions to Runtime ones (fully isolation from Craft CLI) and improved the message. Fixes #750 .

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 56242113, isolating charm_builder.py as a standalone plugin with stdout output and RuntimeError, fixing #750.
stealth/space-bunny-alpha — closed resolved Merged PR #865 as commit 56242113, isolating charm_builder.py as a generic plugin with stdout output and RuntimeError exceptions, resolving #750.
qwen/qwen3.6-35b-a3b — — Merged following approval and CI checks. Isolated charm_builder.py as a standalone plugin script, routing all output to stdout and replacing CraftError with RuntimeError to fully decouple from the Craft CLI. Resolves #750.
qwen3.6-35b-a3b-mtp-q6 — — Merged isolation of charm_builder.py as a standalone plugin script. Replaced CraftError with RuntimeError and converted outputs to stdout prints for full CLI isolation. Resolves #750.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#750 (confidence 100%)

    The PR explicitly states “Fixes #750,” and that issue was closed by this merged change.

Related issues

Issue Project State Summary Similarity
#750 Convert charm_builder.py to a regular external script charmcraft closed Converted charm_builder.py into a standalone script with plain stdout logging and RuntimeError handling via merged PR #865 (commit 56242113).
77%
#453 build: spin off charm builder as a separate tool (CRAFT-373) charmcraft merged Merged #453 in commit 3e5eed05, extracting charm-building routines into a standalone CharmBuilder invoked by build; venv and pip enhancements were deferred.
74%
#452 build: create charm builder tool (CRAFT-373) charmcraft closed Superseded by merged charmcraft#453, which moved charm-building logic to a standalone CharmBuilder; the venv and pip optimizations were deferred.
71%