build: create charm builder tool (CRAFT-373)
Metadata
Current evaluation
Closed due to requested changes and nine unresolved review comments. Author plans to resubmit a cleaner version later, abandoning this iteration.
Suggested action: —
No scores available.
Issue body
Extract the build routine from the Builder class and create a stand-alone
charm builder tool. Invoke the tool from the Builder class passing all the
appropriate arguments to build charms. This tool will be invoked from the
charm plugin after parts integration.
The payload venv is now created from the user site of a staging venv to
cache the previous installation and avoid reinstalling packages that are
already installed. This is done to avoid spending a long time building
packages when binary wheels are disabled.
Charm building tests moved from `tests/commands/test_build.py` to
`tests/test_charm_builder.py`, replacing the `Builder` class with the
`CharmBuilder` class. Additional tests added to verify handling of
package dependencies and pip binaries arguments, and invocation
of the builder tool.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed due to requested changes and nine unresolved review comments. Author plans to resubmit a cleaner version later, abandoning this iteration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned without merging. The author plans to propose a cleaner version that moves existing code without extras at a later date. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The author abandoned this pull request to propose a revised version that moves existing code without adding extras later. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.