← Back to issue list

providers: move `is_base_available()` to providers.py

View original Github issue

Metadata

Project
charmcraft
Number
#896
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #896 (4ab422f8), moving is_base_available() from craft-providers into Charmcraft's providers.py to keep Charmcraft-specific logic outside the shared interface.

Resolution: closed resolved

Reason: The approved refactor was merged via commit 4ab422f8, with implementation commit 981a0bd9.

Evaluated by: mr-cal-bot

No scores available.

Issue body

`is_base_available()` contains charmcraft-specific logic, so it is separated from the craft-providers interface

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #896 (4ab422f8), moving is_base_available() from craft-providers into Charmcraft's providers.py to keep Charmcraft-specific logic outside the shared interface.
stealth/space-bunny-alpha — closed resolved Merged PR #896 (commit 4ab422f8) moved is_base_available() from the craft-providers interface to providers.py, separating Charmcraft-specific logic.
qwen/qwen3.6-35b-a3b — — Merged after approval. Moved the charmcraft-specific is_base_available() function from the craft-providers interface to providers.py to separate concerns. The change affects 8 files, adding 149 lines and removing 201.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer mr-cal to move is_base_available() to providers.py, separating charmcraft-specific logic from the craft-providers interface.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#898 providers: move `get_provider()` to providers.py charmcraft merged Merged charmcraft#898, moving get_provider() into providers.py for CRAFT-1410 after prerequisite charmcraft#896 landed.
82%
#92 providers: refactor get_provider() rockcraft merged Merged PR #92 as commit 5bcc1c80, refactoring get_provider() and moving it from _get_provider.py to providers.py for CRAFT-1375.
71%
#91 providers: move `confirm_with_user()` call to providers.py rockcraft merged Merged PR #91 as b189a224, moving Rockcraft-specific confirm_with_user() into providers.py and renaming is_provider_available() to is_provider_installed().
71%
#3940 providers: move `get_provider()` to providers.py snapcraft merged Merged PR #3940 by mr-cal moved get_provider() into snapcraft/providers.py (squash commit 2acdd89b6), a CRAFT-1409 refactor mirroring canonical/rockcraft#92, part of a series of provider/lifecycle function moves.
70%
#899 providers: use new craft-providers interface charmcraft merged Merged PR #899 (merge commit 538aec31, implementation 5e5acb7c): removed Charmcraft's own Provider/LXDProvider/MultipassProvider classes in favour of craft-providers', and moved charmcraft/providers/providers.py to charmcraft/providers.py. Resolves CRAFT-1279.
70%