← Back to issue list

providers: refactor get_provider()

View original Github issue

Metadata

Project
rockcraft
Number
#92
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #92 as commit 5bcc1c80, refactoring get_provider() and moving it from _get_provider.py to providers.py for CRAFT-1375.

Resolution: closed resolved

Reason: PR #92 was approved and merged as commit 5bcc1c80, completing the get_provider() refactor and module move.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- 1. Refactor `get_provider()` 2. Move `get_provider()` from `_get_provider.py` to `providers.py`. (CRAFT-1375)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #92 as commit 5bcc1c80, refactoring get_provider() and moving it from _get_provider.py to providers.py for CRAFT-1375.
stealth/space-bunny-alpha — closed resolved Merged rockcraft#92 as 5bcc1c80, refactoring get_provider() and moving it from _get_provider.py to providers.py.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Refactored and moved get_provider() from _get_provider.py to providers.py across seven files, reducing code by 25 lines. Resolves CRAFT-1375.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that relocated the get_provider() function from _get_provider.py to providers.py, addressing CRAFT-1375.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#484 providers: refactor to better support multiple providers (CRAFT-362) charmcraft merged Merged PR #484 (commit 93982f90, merge 7a1f50fc) by cjp256 converted providers module into a package for CRAFT-362: added common Provider class, LXDProvider subclass and get_provider(); follow-ups moved get_provider() to providers.py and renamed _helpers to _logs.
83%
#3940 providers: move `get_provider()` to providers.py snapcraft merged Merged PR #3940 by mr-cal moved get_provider() into snapcraft/providers.py (squash commit 2acdd89b6), a CRAFT-1409 refactor mirroring canonical/rockcraft#92, part of a series of provider/lifecycle function moves.
82%
#898 providers: move `get_provider()` to providers.py charmcraft merged Merged charmcraft#898, moving get_provider() into providers.py for CRAFT-1410 after prerequisite charmcraft#896 landed.
82%
#120 providers: use new craft-providers interface rockcraft merged Merged as 3f887b70: replaced Rockcraft's local provider classes with craft-providers and moved providers.py.
75%
#3926 providers: move `get_instance_name()` to providers.py snapcraft merged Merged as commit c1246cbe3 (+82/-45, 6 files): moved the snapcraft-specific get_instance_name() out of craft-providers into snapcraft/providers/providers.py (CRAFT-1305 prep for the new craft-providers API).
74%
#899 providers: use new craft-providers interface charmcraft merged Merged PR #899 (merge commit 538aec31, implementation 5e5acb7c): removed Charmcraft's own Provider/LXDProvider/MultipassProvider classes in favour of craft-providers', and moved charmcraft/providers/providers.py to charmcraft/providers.py. Resolves CRAFT-1279.
73%
#896 providers: move `is_base_available()` to providers.py charmcraft merged Merged PR #896 (4ab422f8), moving is_base_available() from craft-providers into Charmcraft's providers.py to keep Charmcraft-specific logic outside the shared interface.
71%