charmcraft/jujuignore.py: ability to parse .jujuignore
Metadata
Current evaluation
Merged PR #90 via 42c53674, adding .jujuignore parsing and broad tests; follow-up #99 (b9c265a3) enabled project-defined ignore patterns.
Resolution: closed resolved
Reason: PR #90 was approved and merged as commit 42c53674, adding .jujuignore rule parsing, default Juju exclusions, and extensive tests. Follow-up PR #99 later enabled extending those patterns from a project's .jujuignore file.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This adds some tests around functionality for handling .jujuignore rules
so that we can build charms including files based on how users
explicitly state what they want included vs ignored.
This passes the somewhat limited test suite that Charm's jujuignore
handling supported.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #90 via 42c53674, adding .jujuignore parsing and broad tests; follow-up #99 (b9c265a3) enabled project-defined ignore patterns. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #90 (42c53674): jameinel's .jujuignore parser plus a large test suite comparing Charmcraft behaviour against 'git check-ignore'. Follow-up #99 (b9c265a3) later enabled user-extendable patterns. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #90 (42c53674), adding .jujuignore parsing and tests. Project-defined patterns were later enabled in #99 (b9c265a3). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after adding .jujuignore parsing and test coverage to align charmcraft with gitignore rules. Approved by two reviewers and passed CI. Contributor updated tests to match git check-ignore behavior. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds .jujuignore parsing and comprehensive test coverage to charmcraft. Tests align with git check-ignore behavior to ensure charms correctly handle user-defined file inclusion and exclusion rules. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#99
(confidence 95%)
Merged as b9c265a3 and added support for project-defined .jujuignore patterns.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #99 charmcraft/jujuignore.py: Allow extending the list of patterns. | charmcraft | merged | Merged PR #99 via commit b9c265a3, adding JujuIgnore support for extending Juju's default patterns with entries from a project's .jujuignore file. |