charmcraft/jujuignore.py: Allow extending the list of patterns.
Metadata
Current evaluation
Merged PR #99 via commit b9c265a3, adding JujuIgnore support for extending Juju's default patterns with entries from a project's .jujuignore file.
Resolution: closed resolved
Reason: PR #99 was approved and merged into main as commit b9c265a3. The implementation lets builds combine the default ignores with project-specific .jujuignore patterns.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This adds the ability for JujuIgnore to pull in the default ignores and extend them with .jujuignore contents.
I don't have tests around the walk functionality, but I figured I would leave it in there to show you how I was thinking it would look.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #99 via commit b9c265a3, adding JujuIgnore support for extending Juju's default patterns with entries from a project's .jujuignore file. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #99 as commit b9c265a3, allowing project .jujuignore patterns to extend the default ignore rules. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #99 merged as commit b9c265a3, letting JujuIgnore load Juju's default ignore patterns and extend them with a project's .jujuignore contents; approved by facundobatista after an import-style comment. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #99 as commit b9c265a3, extending Charmcraft's default Juju ignore patterns with patterns from project .jujuignore files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #99 (commit b9c265a3), adding JujuIgnore support to extend Juju's default patterns with project .jujuignore contents. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request enabling JujuIgnore to extend default patterns with .jujuignore contents. Approved by reviewers, passed CI, and modified 4 files with 65 additions and 6 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged feature enabling JujuIgnore to load default patterns and extend them with .jujuignore contents. Author addressed import path feedback prior to approval and merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #90 charmcraft/jujuignore.py: ability to parse .jujuignore | charmcraft | merged | Merged PR #90 via 42c53674, adding .jujuignore parsing and broad tests; follow-up #99 (b9c265a3) enabled project-defined ignore patterns. |