← Back to issue list

flake8 support

View original Github issue

Metadata

Project
charmcraft
Number
#92
Type
pull request
State
merged
Author
jameinel
Labels
Created
Updated
Closed

Current evaluation

Merged. Adds .flake8 config to standardize linting, excludes .git and venv to prevent slow manual scans, updates tests to use it, and fixes a minor PEP8 docstring formatting issue. Approved and merged.

Suggested action:

No scores available.

Issue body

Add .flake8 and tweak the tests so that they use that flake8. If we want to bikeshed on the excluded files, I'm happy to tweak it. Essentially by not passing separate arguments to get_style_guide() it finds the .flake8 file, which means manually running 'flake8' (or in my case autopep8) will read the same rules. This also fixes one PEP8 issue found by autopep8 where we didn't have a blank line between a docstring and the next function.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Adds .flake8 config to standardize linting, excludes .git and venv to prevent slow manual scans, updates tests to use it, and fixes a minor PEP8 docstring formatting issue. Approved and merged.
qwen3.6-35b-a3b-mtp-q6 Merged flake8 support by adding a .flake8 config and updating tests. Excludes .git and venv to prevent slow local scans and fixes a missing blank line PEP8 violation in cmdbase.py.
qwen3.6-35b-a3b-mtp-q6 Merged .flake8 configuration and test updates. Excluded .git and venv to prevent manual run slowdowns. Fixed a PEP8 docstring formatting violation. Approved after minor discussion on exclusion rules and whitespace changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2902 static: fix some valid flake8 issues snapcraft merged Merged. Fixed unused typing imports flagged by flake8 across five Python files. Changes were approved, passed CI checks, and integrated into the codebase.
71%
#1745 static tests: upgrade to the newest flake8 snapcraft merged Merged upgrade to the latest flake8 version, resolving all detected linting violations across nine files. The change passed CI checks and received reviewer approval.
71%