← Back to issue list

static tests: upgrade to the newest flake8

View original Github issue

Metadata

Project
snapcraft
Number
#1745
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1745 upgraded static tests to the newest flake8 and fixed detected lint violations across nine files in commit cffca5aa4.

Resolution: closed resolved

Reason: PR #1745 was approved and merged as commit cffca5aa4, updating flake8 and correcting the issues detected by the upgrade.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update to the newest flake8 and fix the issues that it detected. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1745 upgraded static tests to the newest flake8 and fixed detected lint violations across nine files in commit cffca5aa4.
stealth/space-bunny-alpha — closed resolved Merged PR #1745 as commit cffca5aa4, upgrading static tests to the newest flake8 and fixing the lint issues it detected.
stealth/space-bunny-alpha — closed resolved Merged PR #1745 upgraded static tests to the newest flake8 and fixed all lint violations it detected across nine files.
qwen/qwen3.6-35b-a3b — — Merged upgrade to the latest flake8 version, resolving all detected linting violations across nine files. The change passed CI checks and received reviewer approval.
qwen3.6-35b-a3b-mtp-q6 — — Merged upgrade to the latest flake8 version, resolving newly detected static analysis issues. All static and unit tests passed prior to integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2420 static: update to the latest flake8 snapcraft merged Merged PR updated flake8 to the latest version (LP #1807409) plus related static-check tweaks across 18 files (+34/-33); landed as commit 1b9a7d933.
84%
#1807409 move to newer flake8 snapcraft (launchpad) closed Bumped flake8 to the latest version via snapcore/snapcraft#2420 (commit 1b9a7d933, merged Dec 2018), which bumped the pin and made related static-check fixes across 18 files.
72%
#1600022 [Regression] Static tests fail in Yakkety due to flake8 snapcraft (launchpad) closed Fixed the Yakkety flake8 F821 regression in merged PR snapcore/snapcraft#641 (commit 96917ab8d) by correcting exception handling introduced in #632.
70%