← Back to issue list

Move charm library helper functions to their own modules.

View original Github issue

Metadata

Project
charmcraft
Number
#990
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged and superseded by canonical/charmcraft#993, which landed the helper-module refactor for CRAFT-1557 in fb913b8f (merge 8d23a91c).

Resolution: closed superseded

Reason: The author closed #990 after review feedback and reworked the change as canonical/charmcraft#993. That follow-up was merged with implementation commit fb913b8f and merge commit 8d23a91c.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes CRAFT-1557

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by canonical/charmcraft#993, which landed the helper-module refactor for CRAFT-1557 in fb913b8f (merge 8d23a91c).
stealth/space-bunny-alpha — closed superseded PR #990 (CRAFT-1557) was closed unmerged by lengau after facundobatasta requested splitting the extra refactoring out; the refactor was redone and merged as #993 (commit fb913b8f, merge 8d23a91c).
stealth/space-bunny-alpha — closed superseded Closed unmerged after scope changes were requested. The rework landed as merged PR canonical/charmcraft#993, resolving CRAFT-1557 in commit fb913b8f (merge 8d23a91c).
stealth/space-bunny-alpha — closed superseded Closed without merging after reviewers requested a narrower refactor. The author planned to split the changes into two PRs; the narrower replacement, canonical/charmcraft#993, was later merged.
qwen/qwen3.6-35b-a3b — — Closed by author after reviewer requested splitting unrelated test parametrization changes into a separate PR. Author agreed to resubmit the refactoring and test updates as two distinct pull requests.
qwen3.6-35b-a3b-mtp-q6 — — Closed by the author to split the changes into two separate pull requests per reviewer feedback. The PR was not merged and was abandoned.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#993 refactor: Move charm library helper functions to their own modules (CRAFT-1557) charmcraft merged Merged PR #993 refactored CRAFT-1557 by moving charm-library helpers into dedicated modules; implementation fb913b8f, merge 8d23a91c.
85%
#450 parts: add charm plugin (CRAFT-89) charmcraft closed Closed unmerged; CRAFT-89 landed via superseding PR #458, merged as 9dc20872 with implementation commit 437dab55.
72%