refactor: Move charm library helper functions to their own modules (CRAFT-1557)
Metadata
Current evaluation
Merged refactoring extracting charm library helpers into dedicated modules, resolving CRAFT-1557. Approved by one reviewer with no unresolved comments. Modifies seven files, adding 658 lines and removing 587.
Suggested action: —
No scores available.
Issue body
Fixes CRAFT-1557
(Side note: I've got an upcoming PR that implements many of the test changes I made in #990 and takes into account the feedback. It'll be based on this one though.)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring extracting charm library helpers into dedicated modules, resolving CRAFT-1557. Approved by one reviewer with no unresolved comments. Modifies seven files, adding 658 lines and removing 587. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring changes that relocate charm library helper functions to dedicated modules, resolving CRAFT-1557. The update cleans up the codebase and establishes a base for upcoming test improvements. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring changes moving charm library helper functions to dedicated modules, resolving CRAFT-1557. A follow-up pull request will implement related test updates based on this foundation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #46 New functionality from charmcraft (CRAFT-706). | craft-cli | merged | Merged new charmcraft functionality (CRAFT-706) following approval from two reviewers. The update adds approximately 2000 lines across 13 files, successfully integrating the feature set into the codebase. | |
| #1357 refactor: reorganise constants | charmcraft | merged | Merged a refactor reorganizing constants for Charmcraft environment variables, project filenames, and output files/directories across 47 files. Changes include 471 additions and 443 deletions. Approved by four reviewers with no unresolved comments. | |
| #1303 refactor(utils): move charmlibs utilities | charmcraft | merged | Merged a refactor moving charmlibs utilities across eight files, adding 61 lines and removing 42. Approved by two reviewers with zero unresolved comments. | |
| #471 config: add charm part to documentation (CRAFT-356) | charmcraft | merged | Merged changes adding charm configuration documentation to the configuration schema. Approved by two reviewers with zero unresolved comments. Updated two files with 15 additions and one deletion. Resolves CRAFT-356. | |
| #1897 refactor: move parts plugins to their own module | charmcraft | merged | Merged a refactor by maintainer lengau that relocates parts plugins to a dedicated module, decoupling them from craft-parts. Approved by two reviewers, modifying 11 files (+72/-37). | |
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files. | |
| #1622 fix: reorganise charmcraft.yaml preprocessing | charmcraft | merged | Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines). | |
| #783 Added programmatic outputs to charm libraries related commands (CRAFT-1106). | charmcraft | merged | Merged facundobatista's pull request adding programmatic outputs to charm libraries related commands (CRAFT-1106). Approved by one reviewer. Changes modify three files with 552 additions and 168 deletions. | |
| #1334 refactor(parts): move craft-parts related things into their own package | charmcraft | merged | Merged a refactor that moves craft-parts components into a dedicated package. Approved by two reviewers with zero unresolved comments. The change modifies 16 files, adding 960 lines and removing 794. | |
| #1198 tests: add charm library multiple versions update test | charmcraft | merged | Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments. |