refactor: Move charm library helper functions to their own modules (CRAFT-1557)
Metadata
Current evaluation
Merged PR #993 refactored CRAFT-1557 by moving charm-library helpers into dedicated modules; implementation fb913b8f, merge 8d23a91c.
Resolution: closed resolved
Reason: PR #993 was approved and merged, completing CRAFT-1557. The change landed as implementation commit fb913b8f through merge commit 8d23a91c.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes CRAFT-1557
(Side note: I've got an upcoming PR that implements many of the test changes I made in #990 and takes into account the feedback. It'll be based on this one though.)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #993 refactored CRAFT-1557 by moving charm-library helpers into dedicated modules; implementation fb913b8f, merge 8d23a91c. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/charmcraft#993, moving charm library helpers into dedicated modules for CRAFT-1557 (implementation fb913b8f; merge 8d23a91c). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/charmcraft#993 (8d23a91c), extracting charm library helper functions into dedicated modules for CRAFT-1557; implementation commit fb913b8f. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring extracting charm library helpers into dedicated modules, resolving CRAFT-1557. Approved by one reviewer with no unresolved comments. Modifies seven files, adding 658 lines and removing 587. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring changes that relocate charm library helper functions to dedicated modules, resolving CRAFT-1557. The update cleans up the codebase and establishes a base for upcoming test improvements. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
charmcraft#990
(confidence 98%)
The earlier unmerged attempt was replaced by the reworked implementation merged in PR #993.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #990 Move charm library helper functions to their own modules. | charmcraft | closed | Closed unmerged and superseded by canonical/charmcraft#993, which landed the helper-module refactor for CRAFT-1557 in fb913b8f (merge 8d23a91c). | |
| #1897 refactor: move parts plugins to their own module | charmcraft | merged | Merged PR #1897 (commit 392f859b), separating craft-parts plugins into charmcraft/parts/plugins and isolating them from other parts functionality. |