← Back to issue list

feat: charmcraft/pack with typescript

View original Github issue

Metadata

Project
craft-actions
Number
#105
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/craft-actions#105 rewrote charmcraft/pack in TypeScript to match the other pack actions (CRAFT-5205); approved by 2 reviewers, all CI (setup/pack/test-action-code, run-rockcraft-pack-action) passing, +20585/-138 across 14 files.

Resolution: closed resolved

Reason: The pull request itself was the fix: it was approved by two reviewers with no failing checks and merged into main, landing the TypeScript rewrite of charmcraft/pack (CRAFT-5205) alongside the existing TypeScript pack actions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Rewrites `charmcraft/pack` in TypeScript, aligning it with the other pack commands. CRAFT-5205.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/craft-actions#105 rewrote charmcraft/pack in TypeScript to match the other pack actions (CRAFT-5205); approved by 2 reviewers, all CI (setup/pack/test-action-code, run-rockcraft-pack-action) passing, +20585/-138 across 14 files.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-actions#105, rewriting charmcraft/pack in TypeScript to align it with other pack commands for CRAFT-5205.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-actions#105, rewriting charmcraft/pack in TypeScript to align with other pack commands for CRAFT-5205.
qwen3.6-35b-a3b-mtp-q6 — — Merged after approval and passing CI checks. Rewrites the charmcraft/pack command in TypeScript to align with other pack commands, addressing CRAFT-5205. The change modifies 14 files.

Update history

Date Change
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: canonical/craft-actions#1 (confidence 55%)

    rockcraft-pack action, the first of the pack actions this rewrite aligns charmcraft/pack with; same CRAFT-5205 migration effort.

Related issues

Issue Project State Summary Similarity
#45 feat: create new snapcraft-pack action craft-actions merged Merged as commit 8756708, adding a snapcraft/pack action modeled on charmcraft/pack, with shared common/ workflows, working `path` input, and snap/ dir added to the cache key. All CI checks passed; docs followed in #46.
71%
#106 feat(pack)!: allow multiple primary artifacts craft-actions merged Merged PR canonical/craft-actions#106: all three pack actions (snapcraft, charmcraft, rockcraft) now emit multiple primary artifacts when several build-ons match. Workflow artifact output fields pluralized — a deliberate breaking API change. Approved by 2 reviewers, CI fully green.
71%
#439 [docs] how to run charmcraft as part of a CI? charmcraft closed Closed as addressed: canonical/craft-actions#31 (commit 91513c1) added Charmcraft setup and pack actions, and a maintainer confirmed CI packing and publishing were now supported.
71%