← Back to issue list

feat(rockcraft-pack): implement pro field

View original Github issue

Metadata

Project
craft-actions
Number
#42
Type
pull request
State
merged
Author
alesancor1
Labels
—
Created
Updated
Closed

Current evaluation

Merged #42, adding the rockcraft-pack pro input to build pro rocks; the feature landed in commit 299088e.

Resolution: closed resolved

Reason: PR #42 was approved and merged with all CI checks passing. Commit 299088e implements the pro field and passes the corresponding option to rockcraft-pack.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR adds the ability for users to build pro rocks via `--pro` (the `rockcraft-channel` needs to be specified for now as `--pro` does not exists in stable currently).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #42, adding the rockcraft-pack pro input to build pro rocks; the feature landed in commit 299088e.
stealth/space-bunny-alpha — closed resolved Merged PR #42 as commit 299088e, adding --pro support to rockcraft-pack for building pro rocks with a specified rockcraft-channel; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #42 added a pro input and --pro support to rockcraft-pack, enabling Pro rock builds when a non-stable rockcraft-channel is configured.
stealth/space-bunny-alpha — closed resolved Merged #42, adding the --pro flag to rockcraft-pack for building pro rocks when rockcraft-channel is specified. Three reviewers approved it and all CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged implementation of the --pro flag for building pro rocks in rockcraft-pack. Requires rockcraft-channel specification as the flag is unavailable in stable. Approved by three reviewers with all CI checks passing. Title and description noted as outdated prior to merge.

Update history

No update history recorded yet.

Related work

  • Related To: craft-actions#43 (confidence 95%)

    Follow-up PR #43, commit 8a45c52, corrected pro builds to run with root access.

Related issues

Issue Project State Summary Similarity
#40 feat(rockcraft-pack): support rockcraft test craft-actions merged Merged #40 as commit 05e3417, adding rockcraft test support to rockcraft-pack so test workflows can reuse the action's packed rock.
80%
#39 feat(rockcraft-pack): accept env-file input craft-actions closed PR #39 was closed unmerged after internal discussion; the proposed rockcraft-pack env-file input was not adopted, and a required test was missing.
77%
#474 feat: build Rockcraft rock rockcraft closed PR adding rockcraft.yaml to pack Rockcraft itself as a rock (plus a GHCR workflow) was closed unmerged by author cjdcordeiro; no rockcraft.yaml commit landed in rockcraft.
74%
#993 Changes for RK042 - Support for Pro Rocks in Rockcraft - 30/01/25 craft-parts merged Merged craft-parts #993, delivering the craft-parts portion of RK042 Pro Rocks support; the coordinated Rockcraft integration landed in rockcraft#788.
72%
#788 Changes for RK042 - Support for Pro Rocks in Rockcraft - 30/01/25 rockcraft merged Merged PR #788 delivered RK042 Pro Rocks support across 241 files; later Pro Rocks source integration also landed via #1184 (1987d98b).
70%
#57 feat(rockcraft): support --ignore=unmaintained craft-actions merged PR #57 (commit 9f9af04) merged, adding an `ignore` input to rockcraft/rockcraft-pack that passes --ignore=<value> to rockcraft pack, closing feature issue #52. Approved by 3 reviewers with all CI checks green.
70%