← Back to issue list

feat(rockcraft-pack): support rockcraft test

View original Github issue

Metadata

Project
craft-actions
Number
#40
Type
pull request
State
merged
Author
alesancor1
Labels
—
Created
Updated
Closed

Current evaluation

Merged #40 as commit 05e3417, adding rockcraft test support to rockcraft-pack so test workflows can reuse the action's packed rock.

Resolution: closed resolved

Reason: PR canonical/craft-actions#40 was approved and merged with all CI checks passing. Commit 05e3417 added support for running rockcraft test through the rockcraft-pack workflow.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary This PR adds support for `rockcraft test` command as part of the build workflow, since `rockcraft test` implicitly runs `rockcraft pack` before calling spread. This behaviour prevents us from adding `rockcraft test` as another job inside [OCI Factory Test-Rock workflow](https://github.com/canonical/oci-factory/blob/main/.github/workflows/Test-Rock.yaml), as those rely on a previously packed rock by the [Build workflow](https://github.com/canonical/oci-factory/blob/e6432dc8d5e591962de71a5184a86af11a154ea2/.github/workflows/Build-Rock.yaml#L130-L135), where this action is used. Ideally, if `rockcraft test <rock-file>` (or similar) becomes a reality, this logic can be moved to OCI Factory Test-Rock workflow.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #40 as commit 05e3417, adding rockcraft test support to rockcraft-pack so test workflows can reuse the action's packed rock.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-actions#40, adding rockcraft test support to the build workflow, including its implicit pack step; all listed CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged to integrate rockcraft test into the build workflow. The change handles implicit pack execution to avoid OCI Factory duplication. Approved by two reviewers, passed CI, and merged with 218 additions and 12 deletions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#42 feat(rockcraft-pack): implement pro field craft-actions merged Merged #42, adding the rockcraft-pack pro input to build pro rocks; the feature landed in commit 299088e.
80%
#39 feat(rockcraft-pack): accept env-file input craft-actions closed PR #39 was closed unmerged after internal discussion; the proposed rockcraft-pack env-file input was not adopted, and a required test was missing.
78%
#181 Add testing framework? rockcraft open Rockcraft now exposes an upstream-backed rockcraft test command for built-rock testing; commit a6d1b77a added it, and downstream CI supports its implicit pack-and-test flow.
78%
#57 feat(rockcraft): support --ignore=unmaintained craft-actions merged PR #57 (commit 9f9af04) merged, adding an `ignore` input to rockcraft/rockcraft-pack that passes --ignore=<value> to rockcraft pack, closing feature issue #52. Approved by 3 reviewers with all CI checks green.
75%
#474 feat: build Rockcraft rock rockcraft closed PR adding rockcraft.yaml to pack Rockcraft itself as a rock (plus a GHCR workflow) was closed unmerged by author cjdcordeiro; no rockcraft.yaml commit landed in rockcraft.
75%
#1 rockcraft-pack: new action initializing repository craft-actions merged Merged canonical/craft-actions#1, bootstrapping the craft-actions repo with the first action, rockcraft-pack, for building ROCKs with Rockcraft inside GitHub Workflows (+16326/-33 lines, 21 files).
74%
#8 project: add rockcraft.yaml load function (CRAFT-586) rockcraft merged Merged PR #8 added a dedicated rockcraft.yaml loader with tests; merge commit 3cf2d6fa contains implementation commit 85981d00.
73%
#73 refactor: make rockcraft-pack follow new call conventions craft-actions merged Merged PR #73 (bepri): refactored rockcraft-pack into new call conventions — per-tool actions at <tool>/<action>, tests/dists alongside actions, shared behaviour moved from _common/ to common/, mirroring canonical/starflow#155.
72%
#1350 Move Rockcraft to the craft-application mediation framework rockcraft closed Closed after ROCKCRAFT-319 was filed; no PR linked. Related commit 0b6ba8bd (PR #1357, 'skip repacking if project is unchanged') implements the no-repack goal.
71%
#118 feat: pack snapcraft 9 for core26 snapcraft-rocks open Maintainer cmatsuoka adds an experimental rockcraft.yaml plus CI/workflow changes (+179/-3, 3 files) so the build rock can pack with Snapcraft 9 against core26. Open 13 days, unreviewed (0 reviewers), CLA passing, build-rock check still pending.
70%