Support build secrets in destructive mode
Metadata
Current evaluation
PR #102 merged, adding build-secrets support in destructive mode: YAML-service secret handling plus Application rendering. Landed as commit ef5620dd, followed by managed-mode support in #104 (8c6c0475).
Resolution: closed resolved
Reason: The PR itself was merged into main after approval from three reviewers, with the two commits (89232cfc 'feat: add basic secrets api' and ef5620dd 'feat: render build secrets in the Application') landing the destructive-mode build-secrets feature.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The first commit has the code to handle the secrets in yaml data, and the second commit updates the Application to use the first commit's code.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #102 merged, adding build-secrets support in destructive mode: YAML-service secret handling plus Application rendering. Landed as commit ef5620dd, followed by managed-mode support in #104 (8c6c0475). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-application#102, adding build-secret handling in destructive mode through the YAML service and Application. Changes landed as commit ef5620dd. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds build secret support for destructive mode by updating the Application class. Approved by three reviewers with 100% diff coverage. Environment inheritance confirmed for shell and managed modes. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#104
(confidence 90%)
Follow-up merged PR 'feat: support build-secrets in managed-mode' (commit 8c6c0475), explicitly cited in the review discussion as the next piece covering managed mode.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #100 Add support for build secrets | craft-application | closed | Managed-mode build-secret support was merged in canonical/craft-application#104 via commit 8c6c0475. | |
| #104 feat: support build-secrets in managed-mode | craft-application | merged | Merged managed-mode build-secret support in #104 via commit 8c6c0475, encoding host secrets and decoding them in managed instances to re-render project secrets. | |
| #50 spec for handling build-time secrets | craft-application | closed | Build-time secrets were delivered through a secrets API and application rendering; managed-mode support followed in #104. | |
| #378 feat: enable build-secrets | rockcraft | merged | Merged PR #378 enabled build-secrets support, landing a six-file (+48/-4) change on feature/build-secrets after approval by two reviewers. |