Support build secrets in destructive mode
Metadata
Current evaluation
Merged. Adds build secret support for destructive mode by updating the Application class. Approved by three reviewers with 100% diff coverage. Environment inheritance confirmed for shell and managed modes.
Suggested action: —
No scores available.
Issue body
The first commit has the code to handle the secrets in yaml data, and the second commit updates the Application to use the first commit's code.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds build secret support for destructive mode by updating the Application class. Approved by three reviewers with 100% diff coverage. Environment inheritance confirmed for shell and managed modes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged build secrets support for destructive mode. Two commits add YAML parsing and Application integration with 100% diff coverage. Managed mode handling was deferred to a follow-up PR after confirming environment inheritance works correctly. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #104 feat: support build-secrets in managed-mode | craft-application | merged | Merged into main. Implements build-secrets support in managed-mode by encoding secrets into the host-application environment for the managed instance to decode and re-render. Approved by two reviewers, passed CI, and achieved 100% diff coverage. |