← Back to issue list

feat: enable build-secrets

View original Github issue

Metadata

Project
rockcraft
Number
#378
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged to enable build-secrets. Approved by two reviewers, the update modifies six files (+48/-4). The target branch was adjusted to feature/build-secrets before final merge.

Suggested action:

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to enable build-secrets. Approved by two reviewers, the update modifies six files (+48/-4). The target branch was adjusted to feature/build-secrets before final merge.
qwen3.6-35b-a3b-mtp-q6 Merged the build-secrets feature into the feature/build-secrets branch. The maintainer updated the target branch and completed the merge without additional changes or conflicts.
qwen3.6-35b-a3b-mtp-q6 Merged into the feature/build-secrets branch. The change enables build-secrets functionality, with the target branch updated by maintainer tigarmo from TBD to feature/build-secrets.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#104 feat: support build-secrets in managed-mode craft-application merged Merged into main. Implements build-secrets support in managed-mode by encoding secrets into the host-application environment for the managed instance to decode and re-render. Approved by two reviewers, passed CI, and achieved 100% diff coverage.
77%
#483 feat(secrets): support for 'basic' secrets fetch-service merged Merged feature adding support for basic secrets. Approved by three reviewers, passed all CI checks, and modified 14 files with 240 additions and 14 deletions.
75%
#185 feat: add secrets API craft-cli merged Merged the secrets API feature, adding Emitter.set_secrets to mask sensitive strings across all CLI outputs. Approved by two reviewers, passed CI checks, and achieved 100% diff coverage. Resolves issue 184.
73%
#769 feat: add the remote-build command rockcraft merged Merged the remote-build command. Approved by three reviewers, the change adds 86 lines and removes 7 across nine files. Integrated by the maintainer without further comments or CI issues.
71%