← Back to issue list

feat: enable build-secrets

View original Github issue

Metadata

Project
rockcraft
Number
#378
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #378 enabled build-secrets support, landing a six-file (+48/-4) change on feature/build-secrets after approval by two reviewers.

Resolution: closed resolved

Reason: PR #378 was merged after approval from two reviewers, resolving the request to enable build-secrets in Rockcraft.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #378 enabled build-secrets support, landing a six-file (+48/-4) change on feature/build-secrets after approval by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #378 enabled build-secrets, updating six files (+48/-4); the feature branch was approved by two reviewers and merged.
stealth/space-bunny-alpha — closed resolved Merged PR #378 enabled build-secrets, changing six files (+48/-4). Its target was set to feature/build-secrets.
qwen/qwen3.6-35b-a3b — — Merged to enable build-secrets. Approved by two reviewers, the update modifies six files (+48/-4). The target branch was adjusted to feature/build-secrets before final merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged the build-secrets feature into the feature/build-secrets branch. The maintainer updated the target branch and completed the merge without additional changes or conflicts.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#104 feat: support build-secrets in managed-mode craft-application merged Merged managed-mode build-secret support in #104 via commit 8c6c0475, encoding host secrets and decoding them in managed instances to re-render project secrets.
79%
#100 Add support for build secrets craft-application closed Managed-mode build-secret support was merged in canonical/craft-application#104 via commit 8c6c0475.
71%
#657 feat!(secrets): remove secrets craft-application merged Merged PR #657 in commit ad52b56b, removing built-in secrets support; applications can instead integrate secrets through the prototype secrets service.
71%
#102 Support build secrets in destructive mode craft-application merged PR #102 merged, adding build-secrets support in destructive mode: YAML-service secret handling plus Application rendering. Landed as commit ef5620dd, followed by managed-mode support in #104 (8c6c0475).
70%