← Back to issue list

chore: finalize Pro support

View original Github issue

Metadata

Project
craft-application
Number
#1047
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1047 as commit 0455be5d, finalizing Pro support with craft-app v6 compatibility, conflict cleanup, consistent naming, a smaller API, and comprehensive tests.

Resolution: closed resolved

Reason: PR #1047 merged after approval with all CI checks passing. Commit 0455be5d resolves merge conflicts from #1031 and integrates the Pro feature work for craft-app v6.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Finalizes Pro support in its feature branch. I recommend reviewing by commit. Changes: * Clean up of merge conflicts from #1031. * Make feature compatible with craft-app v6. * This feature was written for v4, when the Application was a god class and there was no Project service. * Consistent use of "Pro" and "Ubuntu Pro". * Smaller public API. Many attributes in `pro_services.py` are now internal. * Comprehensive unit tests. (CRAFT-5016)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1047 as commit 0455be5d, finalizing Pro support with craft-app v6 compatibility, conflict cleanup, consistent naming, a smaller API, and comprehensive tests.
stealth/space-bunny-alpha — closed resolved Pro support was finalized in merged PR #1047 (0455be5d), adding craft-app v6 compatibility, conflict cleanup, consistent naming, a smaller public API, and unit tests.
stealth/space-bunny-alpha — closed resolved Merged as commit 0455be5d: finalized Pro support for Craft App v6, resolved #1031 conflicts, standardized naming, reduced the public API, and added unit tests.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI. Finalizes Pro support by updating craft-app v6 compatibility, resolving merge conflicts, standardizing naming, reducing the public API, and adding unit tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged to finalize Pro support. Updates craft-app v6 compatibility, resolves #1031 conflicts, refines the public API, and adds unit tests. The feature branch was integrated into main.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#916 chore: finalize Pro support craft-providers merged Merged as 6545bdb, finalizing Pro support with added tests, unused-code cleanup, stronger error handling, and Copilot-derived suggestions.
85%
#914 [TESTING] chore: finalize Pro support craft-providers closed Testing PR for Pro support was closed unmerged; finalized work continued in #916 and merged as commit 6545bdb.
84%
#1048 chore: make Pro support opt-in craft-application merged Merged opt-in Ubuntu Pro support and clearer error diagnostics in PR #1048 (commit be206d19); released in craft-application 6.3.0.
76%
#1050 chore(merge): feature/pro-sources into main craft-application merged Pro sources support was merged into main by PR #1050 (commit 8c1a7aeb), resolving CRAFT-5016.
75%
#644 chore: update pre-commit hooks craft-providers merged Merged PR #644 updated craft-providers' pre-commit configuration (+4/-3 lines) and landed as commit 5c77e3b.
73%
#903 chore: update craft-providers rockcraft merged Merged #903 as commit 3b18ef58 to update craft-providers; all reported lint, tests, builds, security scans, and policy checks passed.
72%
#923 chore(merge): 2.1.4 into main craft-parts merged Merged craft-parts 2.1.4 back into main via PR #923 (merge commit 92075f67).
72%
#918 chore(merge): feature/pro-sources into main craft-providers merged Merged feature/pro-sources into main via #918 (commit b56ff14), completing CRAFT-5012 with all CI checks passing and 1,594 additions across 9 files.
71%
#478 chore: merge 4.2.3 to main craft-application merged Merged Craft Application 4.2.3 into main via PR #478, resolving in commit 616b3f04 after approval from two reviewers.
71%
#4654 chore: merge feature/components into feature/craft-application snapcraft merged Merged PR #4654 as 76e909dea, integrating feature/components into feature/craft-application and adding core22 component support after test fixes.
71%