chore: finalize Pro support
Metadata
Current evaluation
Merged after approval and CI. Finalizes Pro support by updating craft-app v6 compatibility, resolving merge conflicts, standardizing naming, reducing the public API, and adding unit tests.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Finalizes Pro support in its feature branch.
I recommend reviewing by commit.
Changes:
* Clean up of merge conflicts from #1031.
* Make feature compatible with craft-app v6.
* This feature was written for v4, when the Application was a god class and there was no Project service.
* Consistent use of "Pro" and "Ubuntu Pro".
* Smaller public API. Many attributes in `pro_services.py` are now internal.
* Comprehensive unit tests.
(CRAFT-5016)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and CI. Finalizes Pro support by updating craft-app v6 compatibility, resolving merge conflicts, standardizing naming, reducing the public API, and adding unit tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to finalize Pro support. Updates craft-app v6 compatibility, resolves #1031 conflicts, refines the public API, and adds unit tests. The feature branch was integrated into main. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to finalize Ubuntu Pro support. Updates align the feature with craft-app v6, resolve merge conflicts, restrict the public API, and add unit tests. A preview branch was shared to assist with downstream adjustments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1048 chore: make Pro support opt-in | craft-application | merged | Merged following two approvals and successful CI checks. Implements opt-in Pro support and enhances error message details, resolving CRAFT-5016. | |
| #5260 chore(merge): 8.6.2 into main | snapcraft | merged | Merged release 8.6.2 into main. Adjusted the craft-providers dependency bump to accommodate recent main branch changes. Approved by two reviewers with passing CI checks. | |
| #221 chore(merge): 2.6.2 into main | craft-store | merged | Merged into main after passing CI and receiving two approvals. Backports a fix from craft-store PR #175 to resolve snapcraft issue #5077, addressing a regression from the craft-store 3.0 upgrade. A follow-up craft-store release is planned. | |
| #2159 chore: prepare 3.4.3 release | charmcraft | merged | Merged following approval from two reviewers. Updates the craft-providers dependency and release notes to prepare for the 3.4.3 release. | |
| #903 chore: update craft-providers | rockcraft | merged | The craft-providers update was merged after receiving approval from two reviewers and passing all CI checks. Changes affected two files with minor adjustments (+5/-5 lines). | |
| #2855 chore: update craft-parts for regression fix | charmcraft | merged | Merged to update the craft-parts dependency and resolve a regression. The commit includes an automatic lint fix, received two approvals, and passed CI validation before integration. | |
| #463 chore(deps): update internal packages | rockcraft | merged | Merged automated dependency updates for craft-application, craft-cli, and craft-providers. Approved by two reviewers, passed CI checks, and integrated into main. Changes apply minor version bumps and internal fixes. | |
| #843 chore: merge 5.6.3 to main | craft-application | merged | Merged into main following two reviewer approvals and successful CI checks. The change applied version 5.6.3 updates across three files with minimal modifications. | |
| #1050 chore(merge): feature/pro-sources into main | craft-application | merged | Merged feature/pro-sources into main, resolving CRAFT-5016. Approved by two reviewers and passed CI checks. Adds 1554 lines across 19 files. | |
| #1414 chore(deps): use craft-providers 1.19.3 | charmcraft | merged | Merged dependency update to craft-providers 1.19.3, resolving cache directory deletion issues. Approved by two reviewers, passed CI checks, and integrated without unresolved comments. |