← Back to issue list

feat: add prune instances

View original Github issue

Metadata

Project
craft-application
Number
#1058
Type
pull request
State
open
Author
Aeonoi
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a prune-instances command (+249/-2, 9 files) for removing non-base provider instances, closing #991. Idle ~150 days with 28 unresolved review comments and failing lint, fast-test and minimum-deps CI checks; changelog entry still missing.

Suggested action: keep open

Reason: The underlying feature is still wanted: issue #991 is open and its dependency craft-providers#925 (prune method) is merged and released as 3.6.0, which mr-cal pointed the author to. However the PR is not mergeable as-is: 28 unresolved review comments, 0 reviewers, failing 'lint / files', 'Fast tests' and 'Minimum dependencies' checks, and the PR body's changelog checkbox is still unchecked; the author also expressed uncertainty that 'the prune-instances method is actually done right'. It predates large breaking merges (chore!: remove managed commands #1077, remove deprecated APIs #1078, ty replacing mypy/pyright #1084), so it likely needs reworking, but 150 days of silence is not on its own grounds for closing.

Evaluated by: mr-cal-bot

Impact: 40 Quick Win: 4 Complexity: 45 Confidence: 72 Actionability: 18

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? closes #991 ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 40
Quick Win: 4
Complexity: 45
Confidence: 72
Actionability: 18
keep open Adds a prune-instances command (+249/-2, 9 files) for removing non-base provider instances, closing #991. Idle ~150 days with 28 unresolved review comments and failing lint, fast-test and minimum-deps CI checks; changelog entry still missing.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 9
Complexity: 40
Confidence: 70
Actionability: 30
keep open Adds prune instances feature to craft-application. PR has 28 unresolved review comments, multiple failing CI checks, and last activity 138 days ago.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 25
Staleness: 55
Complexity: 45
Confidence: 75
close stale Adds a prune-instances command to craft-application (closes #991), +249/-2 across 9 files. Author updated the craft-providers pin per maintainer guidance, but has been silent since 2026-05-05; 28 unresolved review comments and several failing CI checks remain.
qwen/qwen3.6-35b-a3b
Staleness: 45
Complexity: 55
Confidence: 85
needs review Adds prune instances feature to close #991. Currently pending maintainer review with 28 unresolved comments and failing CI checks. Contributor updated dependencies per guidance but awaits further review and CI fixes.
qwen3.6-35b-a3b-mtp-q6
Staleness: 60
Complexity: 30
Confidence: 70
keep open Adds prune instances feature and updates dependencies to craft-providers 3.6.0. Currently awaiting contributor update to incorporate the new upstream release and address pending linting fixes.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#991 (confidence 95%)

    The enhancement issue this PR closes; still open, so the feature is not obsolete.

  • Blocked By: craft-providers#925 (confidence 90%)

    Provides the Provider.prune() API this command depends on; merged and shipped in craft-providers 3.6.0, which the author still needed to pin.

  • Related To: canonical/craft-application#1047 (confidence 55%)

    Cited by mr-cal as the example commit for the pyproject/uv.lock update the author needed.

Related issues

Issue Project State Summary Similarity
#991 Add a prune-instances command craft-application open Enhancement to add a prune-instances command for removing non-base provider instances. Upstream craft-providers blockers (#639, #893) are now closed; implementation sits in stalled open PR #1058 with 28 unresolved review comments and failing CI.
83%
#925 feat: add prune method craft-providers merged Merged PR #925 as commit 9836260, adding Provider.prune with LXD and Multipass implementations and tests; it closes issue #893.
76%