chore!: remove Application.run_managed
Metadata
Current evaluation
Closed without merging due to unresolved review comments and failing CI tests. The author abandoned the PR to submit a fresh one.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
This PR cleans up cruft leftover from previous refactors related to the overloaded term `run_managed`.
Commit 1:
- Adds a new property, `AppCommand.runs_managed`.
- Deprecates `AppCommand.run_managed` in favor of the new property.
Commit 2:
- Removes the public `Application.run_managed()` function.
- Adds a new private function, `Application._run_managed()`, that now calls `ProviderService.run_managed()`.
Fixes #1062
(CRAFT-5150)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to unresolved review comments and failing CI tests. The author abandoned the PR to submit a fresh one. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closing the refactoring PR to remove Application.run_managed, the maintainer abandoned the changes to submit a fresh PR instead. The code was not merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned. The author will resubmit the Application.run_managed refactoring as a fresh pull request instead of merging this closed PR. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5237 chore: test backstage | snapcraft | closed | Closed without merging. Appears to be a test submission with no reviews, CI checks, or comments. Likely abandoned or closed by the maintainer to verify repository workflows. | |
| #386 chore:(merge): merge 1.0.1 to main | starbase | closed | Closed and abandoned after the author noted the pull request was submitted to the wrong repository. No review or merge occurred. | |
| #1121 chore: minor cleanup | craft-application | closed | Closed without merging due to a failing Canonical CLA check and lack of reviewer engagement. The minor cleanup changes were abandoned. | |
| #453 chore: merge origin/main | rockcraft | closed | Closed without merging. The maintainer-initiated synchronization PR received no reviews or CI checks and was abandoned, likely superseded by a newer branch update. | |
| #284 chore: merge in starbase | craft-store | closed | Closed without merging due to failing CI checks (OSV-scanner, lint, conventional commits) and zero reviewer approvals. The pull request was abandoned. | |
| #6063 chore: rebase onto main | snapcraft | closed | Closed without merging. Contained zero code changes and only rebased onto main. No reviewers or CI checks were involved, indicating it was abandoned as unnecessary. | |
| #4483 chore(deps): update documentation dependencies | snapcraft | closed | Closed without merging. The documentation dependency update received no reviews or CI checks and was abandoned. A Codecov report flagged missing coverage and a slight percentage drop before closure. | |
| #528 chore: add fake change | craft-application | closed | Closed without merging. The pull request added a single line of code, received no reviewer attention, and was abandoned after sitting idle for approximately 90 days. | |
| #30 chore: merge starbase | craft-grammar | closed | Closed without review or CI checks. Likely merged directly by the maintainer or abandoned. | |
| #5821 chore(legacy): remove script entry point | snapcraft | merged | Merged removal of a legacy script entry point causing user confusion. Approved by two reviewers, passed CI checks, and deleted a single line in one file to clean up the codebase. |