chore!: remove Application.run_managed
Metadata
Current evaluation
Closed unmerged and replaced by #1077, which removed managed-command APIs and completed the ProviderService migration in commit e00540d1.
Resolution: closed superseded
Reason: The maintainer stated that a fresh PR would be created, and PR #1075 was closed without merging. PR #1077 superseded it and was merged as commit e00540d1, removing Application.run_managed and the related managed-command APIs.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
This PR cleans up cruft leftover from previous refactors related to the overloaded term `run_managed`.
Commit 1:
- Adds a new property, `AppCommand.runs_managed`.
- Deprecates `AppCommand.run_managed` in favor of the new property.
Commit 2:
- Removes the public `Application.run_managed()` function.
- Adds a new private function, `Application._run_managed()`, that now calls `ProviderService.run_managed()`.
Fixes #1062
(CRAFT-5150)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and replaced by #1077, which removed managed-command APIs and completed the ProviderService migration in commit e00540d1. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; work was replaced by #1077, merged as e00540d1 to remove managed commands and complete the ProviderService migration. | |
| stealth/space-bunny-alpha | — | closed stale | PR #1075 was closed unmerged after failing CI and nine unresolved review comments; the author said they would submit a fresh PR. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to unresolved review comments and failing CI tests. The author abandoned the PR to submit a fresh one. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closing the refactoring PR to remove Application.run_managed, the maintainer abandoned the changes to submit a fresh PR instead. The code was not merged. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-application#1077
(confidence 100%)
Replacement PR merged as commit e00540d1 and completed the ProviderService migration.
-
Related To:
canonical/craft-application#1062
(confidence 100%)
Original removal issue targeted by the abandoned change and resolved by #1077.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1077 chore!: remove managed commands | craft-application | merged | Merged PR #1077 as commit e00540d1, removing managed-command APIs so managed instances launch only through ProviderService as part of the breaking 7.0.0 cleanup. | |
| #1062 Remove Application.run_managed | craft-application | closed | Merged PR #1077 (e00540d1) removed Application and BaseCommands managed-command APIs; commands now use ProviderService directly, completing the clarified cleanup in 7.0.0. | |
| #1773 chore: remove unused providers module | charmcraft | closed | PR #1773 was closed unmerged after 720 days of inactivity; the providers cleanup was later completed by merged PR #1776 at commit 027696be. | |
| #718 fix!(Application): remove run_managed | craft-application | closed | Closed unmerged; the Application.run_managed cleanup was later merged in PR #1077 via commit e00540d1. |