← Back to issue list

chore!: remove managed commands

View original Github issue

Metadata

Project
craft-application
Number
#1077
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged a breaking change removing unused managed commands to finalize the migration to ProviderService. Resolves #1062. Approved by three reviewers with all CI checks passing prior to integration.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- This PR is a breaking change that completes the migration of where managed instances are dispatched. Now, launching a managed instance can only be done through the `ProviderService`. The `LifecycleCommand`s have been doing this for a while, so the removed code in this PR was unused by Craft Application itself. Unless your app had a custom, non-lifecycle command that runs a managed instance, you should be unaffected by this change. Fixes #1062 (CRAFT-5150)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a breaking change removing unused managed commands to finalize the migration to ProviderService. Resolves #1062. Approved by three reviewers with all CI checks passing prior to integration.
qwen3.6-35b-a3b-mtp-q6 Merged a breaking change that removes unused managed commands, completing the migration to ProviderService and resolving #1062.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6035 chore!: remove deprecated commands snapcraft merged Merged after maintainer approval and a clean rebase. The changes remove deprecated commands and options, resolving issue #5674.
78%
#393 chore: drop mantic from provider test craft-application merged Merged changes to remove mantic from provider tests, as it is no longer supported in craft-providers. Approved by two reviewers, passed CI checks, and integrated into the codebase.
74%
#5540 chore: resolve deprecation warnings snapcraft merged Merged to resolve deprecation warnings before they become errors. Updates test mocking context manager setup. Approved by two reviewers and merged despite one failing integration test. Closes #5539.
74%
#6010 chore!: remove remote-build service override snapcraft merged Merged cleanup removing the remote-build service override and manual spread tests. This follow-up addresses overlooked work from PR #5994. Approved by two reviewers, modifying seven files.
72%
#1538 chore: replace most lifecycle commands with upstream ones charmcraft merged Merged. Replaced most lifecycle commands with upstream versions, removing 297 lines across two files. Approved by three reviewers. Unit tests were not removed since only the pack command had substantial tests, which still requires upstream extension.
72%
#5260 chore(merge): 8.6.2 into main snapcraft merged Merged release 8.6.2 into main. Adjusted the craft-providers dependency bump to accommodate recent main branch changes. Approved by two reviewers with passing CI checks.
72%
#2153 chore: merge 3.4.2 to main charmcraft merged Merged maintainer lengau's chore to integrate version 3.4.2 into main. Approved by three reviewers with minimal changes (+6/-1 across two files). Successfully completed without CI failures or blockers.
71%
#520 chore: rename parameter to "--enable-fetch-service" craft-application merged Merged a non-breaking chore renaming the CLI parameter to --enable-fetch-service to align with existing enabling flags. Approved by two reviewers, passed CI, and modified three files.
71%
#2359 chore: merge 3.5.2 to main charmcraft merged Merged branch 3.5.2 into main, resolving a conflict over the deleted bundle.yaml reference. All other changes came from existing PRs. Approved by two reviewers, CI passed except for known flaky tests.
71%
#5821 chore(legacy): remove script entry point snapcraft merged Merged removal of a legacy script entry point causing user confusion. Approved by two reviewers, passed CI checks, and deleted a single line in one file to clean up the codebase.
71%