← Back to issue list

chore!: remove managed commands

View original Github issue

Metadata

Project
craft-application
Number
#1077
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1077 as commit e00540d1, removing managed-command APIs so managed instances launch only through ProviderService as part of the breaking 7.0.0 cleanup.

Resolution: closed resolved

Reason: PR #1077 was merged with commit e00540d1 after approval and with all checks passing. It fixes issue #1062 by removing the unused Application and BaseCommands managed-command APIs.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- This PR is a breaking change that completes the migration of where managed instances are dispatched. Now, launching a managed instance can only be done through the `ProviderService`. The `LifecycleCommand`s have been doing this for a while, so the removed code in this PR was unused by Craft Application itself. Unless your app had a custom, non-lifecycle command that runs a managed instance, you should be unaffected by this change. Fixes #1062 (CRAFT-5150)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1077 as commit e00540d1, removing managed-command APIs so managed instances launch only through ProviderService as part of the breaking 7.0.0 cleanup.
stealth/space-bunny-alpha — closed resolved Merged PR #1077 (e00540d1), removing managed commands so managed instances launch only through ProviderService and closing #1062.
qwen/qwen3.6-35b-a3b — — Merged a breaking change removing unused managed commands to finalize the migration to ProviderService. Resolves #1062. Approved by three reviewers with all CI checks passing prior to integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged a breaking change that removes unused managed commands, completing the migration to ProviderService and resolving #1062.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#1062 (confidence 100%)

    The PR explicitly states that it fixes the removal of Application.run_managed.

Related issues

Issue Project State Summary Similarity
#1075 chore!: remove Application.run_managed craft-application closed Closed unmerged and replaced by #1077, which removed managed-command APIs and completed the ProviderService migration in commit e00540d1.
85%
#1062 Remove Application.run_managed craft-application closed Merged PR #1077 (e00540d1) removed Application and BaseCommands managed-command APIs; commands now use ProviderService directly, completing the clarified cleanup in 7.0.0.
75%