← Back to issue list

fix(remotebuild): allow building projects with dangling symlinks

View original Github issue

Metadata

Project
craft-application
Number
#1100
Type
pull request
State
closed
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Superseded by an alternative PR. The author closed this dangling symlink fix without merging, opting for @bepri's approach to avoid unmocking tests and unnecessary refactoring.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes a bug from the snapcraft clinic, where a project (one of our own projects!) couldn't be remote built due to dangling symlinks.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded by an alternative PR. The author closed this dangling symlink fix without merging, opting for @bepri's approach to avoid unmocking tests and unnecessary refactoring.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 20
Confidence: 85
needs review Fixes remote build failures caused by dangling symlinks. Author is a maintainer, checklist is complete, and the PR is newly opened awaiting initial review and CI validation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1104 fix(remote-build): ignore dangling symlinks craft-application merged Merged after resolving conflicts with origin/main. The fix ignores dangling symlinks in remote builds and is included in the unreleased 7.1.1 release. Despite author noting it duplicates #1100, it gained two approvals and passed CI.
80%
#1103 Remote build fails on dangling symlinks craft-application closed Closed without resolution. Remote-build crashes during project directory copying when dangling symlinks are present, causing a shutil.Error. No fix or follow-up was provided.
72%
#3370 repo: address issue with fix_symlink() when pointed at directory snapcraft merged Merged fix addressing fix_symlink() crashes when targeting directories. Updates behavior to warn about dangling symlinks, includes refactoring and documentation, and was approved by reviewers prior to merge.
71%