← Back to issue list

fix(remotebuild): allow building projects with dangling symlinks

View original Github issue

Metadata

Project
craft-application
Number
#1100
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #1100 by mr-cal fixed remote builds failing on dangling symlinks, but was closed unmerged in favour of @bepri's PR #1104, which merged the same fix for #1103 in craft-application 7.1.1.

Resolution: closed superseded

Reason: Maintainer mr-cal closed #1100 without merging after @lengau suggested its test should be a unit test; mr-cal agreed the regression "doesn't warrant the extra effort to unmock it and bother setting up a full repo" and favoured @bepri's PR instead. That PR, #1104, was merged and released in craft-application 7.1.1, fixing issue #1103.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes a bug from the snapcraft clinic, where a project (one of our own projects!) couldn't be remote built due to dangling symlinks.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #1100 by mr-cal fixed remote builds failing on dangling symlinks, but was closed unmerged in favour of @bepri's PR #1104, which merged the same fix for #1103 in craft-application 7.1.1.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #1104, which merged the remote-build fix to ignore dangling symlinks for craft-application 7.1.1.
qwen/qwen3.6-35b-a3b — — Superseded by an alternative PR. The author closed this dangling symlink fix without merging, opting for @bepri's approach to avoid unmocking tests and unnecessary refactoring.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-application#1104 (confidence 98%)

    bepri's equivalent fix (ignore dangling symlinks when copying the project) was merged and shipped in 7.1.1; mr-cal explicitly said he was in favour of using it instead of #1100.

  • Related To: canonical/craft-application#1103 (confidence 95%)

    The upstream bug report (Remote build fails on dangling symlinks) that #1104 fixed and which #1100 also addressed.

  • Related To: canonical/snapcraft#5384 (confidence 55%)

    Downstream snapcraft report of remote-build following symlinks; impacted by the craft-application 7.1.1 fix.

Related issues

Issue Project State Summary Similarity
#1104 fix(remote-build): ignore dangling symlinks craft-application merged Merged PR #1104 (commit 8256b7a2) makes remote-build copy the work tree with ignore_dangling_symlinks=True, fixing #1103. Merge conflicts resolved and changelog entry shipped under 7.1.1.
78%
#5384 remote build: snapcraft incorrectly follows symlinks snapcraft open remote-build previously failed while copying dangling symlinks; craft-application 7.1.1 fixed this via PR #1104, and Snapcraft now requires craft-application >=7.4.1.
76%
#1103 Remote build fails on dangling symlinks craft-application closed remote-build crashed with shutil.Error on dangling symlinks because worktree copytree used default symlinks=False. Fixed by merged PR #1104 (commit 8256b7a2), which passes ignore_dangling_symlinks=True to copytree; released in 7.1.1.
75%
#721 Don't follow symlinks for remote-builds craft-application open Remote-build worktree copy still follows symlinks and has no try/except around copytree, so copy failures bubble up as internal errors. Only dangling-symlink skipping (PR #1104) landed.
73%