fix(remote-build): ignore dangling symlinks
Metadata
Current evaluation
Merged PR #1104 (commit 8256b7a2) makes remote-build copy the work tree with ignore_dangling_symlinks=True, fixing #1103. Merge conflicts resolved and changelog entry shipped under 7.1.1.
Resolution: closed resolved
Reason: PR #1104 was approved by 2 reviewers and merged as commit 8256b7a2 "fix(remote-build): ignore dangling symlinks (#1104)", adding ignore_dangling_symlinks=True to the copytree call in craft_application/remote/worktree.py plus a unit test and a changelog entry for 7.1.1. It closed issue #1103, which it explicitly fixes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Fixes #1103.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1104 (commit 8256b7a2) makes remote-build copy the work tree with ignore_dangling_symlinks=True, fixing #1103. Merge conflicts resolved and changelog entry shipped under 7.1.1. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged commit 8256b7a2 makes remote-build skip dangling symlinks when copying the project work tree; fixes #1103, ships in craft-application 7.1.1. Supersedes duplicate PR #1100. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1104 makes remote builds ignore dangling symlinks when copying projects, fixing #1103; its changelog entry targets craft-application 7.1.1. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving conflicts with origin/main. The fix ignores dangling symlinks in remote builds and is included in the unreleased 7.1.1 release. Despite author noting it duplicates #1100, it gained two approvals and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
60
Quick Win:
45
Staleness:
25
Complexity:
25
Confidence:
85
|
needs review | Fixes remote build failures caused by dangling symlinks. PR has 2 approvals, 0 unresolved comments, and passing CI. Merge conflicts were resolved 6 days ago. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Fixes dangling symlinks in remote builds by updating file handling logic. PR has two approvals, zero unresolved comments, and passing CI. Merge conflicts were recently resolved, leaving it ready for final maintainer review and merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
15
Complexity:
20
Confidence:
85
|
needs review | Fixes dangling symlinks in remote builds. Approved by two reviewers, but contains six unresolved review comments and two failing CI checks. Merge conflicts were recently resolved. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
75
Complexity:
20
Confidence:
90
|
close stale | Fixes dangling symlinks in remote builds. Author marked it as a duplicate of #1100, making it superseded and inactive. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated |
Related work
-
Likely Fixed By:
canonical/craft-application#1103
(confidence 98%)
Issue 'Remote build fails on dangling symlinks'; the PR body states 'Fixes #1103' and the issue is now closed by the merged change.
-
Superseded By:
canonical/craft-application#1100
(confidence 90%)
Earlier PR by mr-cal for the same dangling-symlink fix, closed unmerged; maintainer bepri commented 'Duplicate of #1100' context, with #1104 becoming the merged fix.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1103 Remote build fails on dangling symlinks | craft-application | closed | remote-build crashed with shutil.Error on dangling symlinks because worktree copytree used default symlinks=False. Fixed by merged PR #1104 (commit 8256b7a2), which passes ignore_dangling_symlinks=True to copytree; released in 7.1.1. | |
| #721 Don't follow symlinks for remote-builds | craft-application | open | Remote-build worktree copy still follows symlinks and has no try/except around copytree, so copy failures bubble up as internal errors. Only dangling-symlink skipping (PR #1104) landed. | |
| #1100 fix(remotebuild): allow building projects with dangling symlinks | craft-application | closed | PR #1100 by mr-cal fixed remote builds failing on dangling symlinks, but was closed unmerged in favour of @bepri's PR #1104, which merged the same fix for #1103 in craft-application 7.1.1. | |
| #4480 fix(remote): return error when remote build failed | snapcraft | merged | Merged PR #4480 as commit 13aedd1d2, making remote builds return an error when a build fails and fixing #4142. | |
| #4432 fix(remote-build): improve logging and catch exceptions | snapcraft | merged | Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab. |