← Back to issue list

fix(remote-build): ignore dangling symlinks

View original Github issue

Metadata

Project
craft-application
Number
#1104
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged after resolving conflicts with origin/main. The fix ignores dangling symlinks in remote builds and is included in the unreleased 7.1.1 release. Despite author noting it duplicates #1100, it gained two approvals and passed CI.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Fixes #1103.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after resolving conflicts with origin/main. The fix ignores dangling symlinks in remote builds and is included in the unreleased 7.1.1 release. Despite author noting it duplicates #1100, it gained two approvals and passed CI.
qwen3.6-35b-a3b-mtp-q6
Impact: 60
Quick Win: 45.0
Staleness: 25
Complexity: 25
Confidence: 85
needs review Fixes remote build failures caused by dangling symlinks. PR has 2 approvals, 0 unresolved comments, and passing CI. Merge conflicts were resolved 6 days ago.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Fixes dangling symlinks in remote builds by updating file handling logic. PR has two approvals, zero unresolved comments, and passing CI. Merge conflicts were recently resolved, leaving it ready for final maintainer review and merge.
qwen/qwen3.6-35b-a3b
Staleness: 15
Complexity: 20
Confidence: 85
needs review Fixes dangling symlinks in remote builds. Approved by two reviewers, but contains six unresolved review comments and two failing CI checks. Merge conflicts were recently resolved.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 20
Confidence: 90
close stale Fixes dangling symlinks in remote builds. Author marked it as a duplicate of #1100, making it superseded and inactive.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 10
Confidence: 95
close stale Fixes dangling symlinks in remote builds. Author explicitly notes it is a duplicate of #1100, making it redundant.

Update history

Date Change
updated
updated
updated

Related issues

Issue Project State Summary Similarity
#1100 fix(remotebuild): allow building projects with dangling symlinks craft-application closed Superseded by an alternative PR. The author closed this dangling symlink fix without merging, opting for @bepri's approach to avoid unmocking tests and unnecessary refactoring.
80%
#625 fix(remote-build): don't cleanup after a timeout craft-application merged Merged fix preventing remote builder cleanup after timeouts and removing references to a non-existent --build-id option. Approved by two reviewers, passed CI, and rebased to main for release 4.8.3. Resolves #618 and #619.
72%
#4826 fix(remote-build): fail if no artifacts are created snapcraft merged Merged fix for issue #4783 that ensures remote builds fail when no artifacts are generated. Approved by two reviewers, passed CI, and merged with 214 additions and 4 deletions across two files.
71%
#4480 fix(remote): return error when remote build failed snapcraft merged Successfully merged fix for remote build failures that returns proper errors, resolving issue #4142. Approved by three reviewers with maintained code coverage across 13 files.
70%