← Back to issue list

fix: fail fast on unsupported lifecycle bases

View original Github issue

Metadata

Project
craft-application
Number
#1162
Type
pull request
State
open
Author
lengaubot
Labels
—
Created
Updated
Closed
—

Current evaluation

Moves unsupported-base check before lifecycle init to fail fast. PR is inactive (18 days, 0 comments) and appears superseded by merged PR #263 which implements the same base compatibility check.

Suggested action: close stale

Reason: The feature this PR implements (failing fast on unsupported lifecycle bases) was already merged in craft-application#263, which "Introduces a base compatibility check in the Lifecycle service to block builds on mismatched host OS environments." PR #251 was also closed as superseded by #263. This PR is now redundant.

Impact: 20 Quick Win: 17.0 Staleness: 85 Complexity: 15 Confidence: 75

Issue body

Fail unsupported-base lifecycle commands before provider setup. This moves the unsupported-base check ahead of lifecycle initialization so the command returns the expected error without triggering an unnecessary LXC profile lookup during startup. Validation: targeted test could not be executed in this environment because craft_cli is unavailable outside the repo venv.

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 20
Quick Win: 17.0
Staleness: 85
Complexity: 15
Confidence: 75
close stale Moves unsupported-base check before lifecycle init to fail fast. PR is inactive (18 days, 0 comments) and appears superseded by merged PR #263 which implements the same base compatibility check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 85
needs review Moves unsupported-base check before lifecycle init to fail fast and avoid unnecessary LXC profile lookups. All CI checks pass or are pending. Awaiting maintainer review.

Update history

Date Change
created

Related work

  • Duplicate Of: craft-application#263 (confidence 80%)

    PR #263 was merged and implements the same base compatibility check functionality described in this PR's title and body.

  • Duplicate Of: craft-application#251 (confidence 70%)

    PR #251 was closed and explicitly noted as superseded by #263, covering the same lifecycle base compatibility requirement.

Related issues

Issue Project State Summary Similarity
#251 feat(lifecycle)!: don't build on incompatible bases craft-application closed Proposed build base compatibility checks were closed and superseded by pull request #263, which addressed the same lifecycle service requirement.
77%
#263 feat(lifecycle)!: don't build on incompatible bases craft-application merged Merged following reviewer approval and CI passes. Introduces a base compatibility check in the Lifecycle service to block builds on mismatched host OS environments, resolving issue #154.
76%
#730 Remove base support craft-parts open Task to remove the deprecated 'base' parameter from LifecycleManager and related base support. The parameter still exists in current code (lifecycle_manager.py, infos.py, main.py), so the work is unaddressed; no labels or maintainer activity beyond an auto Jira-sync comment.
71%