← Back to issue list

fix: fail fast on unsupported lifecycle bases

View original Github issue

Metadata

Project
craft-application
Number
#1162
Type
pull request
State
open
Author
lengaubot
Labels
—
Created
Updated
Closed
—

Current evaluation

Reorders the unsupported-base check ahead of lifecycle initialization to avoid an unnecessary LXC profile lookup; all completed checks pass, while several remain pending and review is pending.

Suggested action: needs review

Reason: The focused three-line reorder has no failing completed checks and no unresolved review comments, making it ready for maintainer review. However, several CI jobs remain pending, no maintainer has reviewed it, and the targeted test was not run locally, so immediate merge is not yet warranted.

Evaluated by: mr-cal-bot

Impact: 38 Quick Win: 25 Complexity: 12 Confidence: 87 Actionability: 76

Issue body

Fail unsupported-base lifecycle commands before provider setup. This moves the unsupported-base check ahead of lifecycle initialization so the command returns the expected error without triggering an unnecessary LXC profile lookup during startup. Validation: targeted test could not be executed in this environment because craft_cli is unavailable outside the repo venv.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 38
Quick Win: 25
Complexity: 12
Confidence: 87
Actionability: 76
needs review Reorders the unsupported-base check ahead of lifecycle initialization to avoid an unnecessary LXC profile lookup; all completed checks pass, while several remain pending and review is pending.
stealth/space-bunny-alpha
Impact: 42
Quick Win: 27
Complexity: 10
Confidence: 89
Actionability: 72
needs review Moves unsupported-base validation ahead of build-plan/provider setup, avoiding an LXC profile lookup before the intended error. No reviews; completed CI is green, with Fast and OpenStack checks pending.
qwen3.6-35b-a3b-mtp-q6
Impact: 20
Quick Win: 17
Staleness: 85
Complexity: 15
Confidence: 75
close stale Moves unsupported-base check before lifecycle init to fail fast. PR is inactive (18 days, 0 comments) and appears superseded by merged PR #263 which implements the same base compatibility check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 85
needs review Moves unsupported-base check before lifecycle init to fail fast and avoid unnecessary LXC profile lookups. All CI checks pass or are pending. Awaiting maintainer review.

Update history

Date Change
created

Related work

  • Related To: craft-application#251 (confidence 96%)

    Introduced the lifecycle incompatibility behavior that this ordering fix makes fail faster.

  • Related To: craft-application#263 (confidence 94%)

    Merged implementation of the lifecycle base and host compatibility check.

Related issues

No related issues found above the similarity threshold.