← Back to issue list

feat(lifecycle)!: don't build on incompatible bases

View original Github issue

Metadata

Project
craft-application
Number
#251
Type
pull request
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favour of canonical/craft-application#263, which merged as commit b916620e adding the Lifecycle base/host compatibility check and fixing issue #154.

Resolution: closed superseded

Reason: Maintainer tigarmo closed PR #251 on 2024-03-11 with the comment "Closing in preference of #263" after handing it to sergiusens. PR #263 was later merged, landing commit b916620e "feat(lifecycle)!: don't build on incompatible bases (#263)", which implements the same feature and closes issue #154.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The Lifecycle service will now check whether the build's base (as stored in the BuildInfo) matches the running environment. This doesn't affect managed runs (barring bugs), but is a change in behavior as we will no longer build, say, Ubuntu 22.04 artifacts on Fedora hosts in destructive mode. Fixes #154 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favour of canonical/craft-application#263, which merged as commit b916620e adding the Lifecycle base/host compatibility check and fixing issue #154.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of canonical/craft-application#263, which merged the Lifecycle base/host compatibility check and fixes #154.
qwen/qwen3.6-35b-a3b — — Proposed build base compatibility checks were closed and superseded by pull request #263, which addressed the same lifecycle service requirement.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-application#263 (confidence 99%)

    Same title and intent; merged as commit b916620e and delivered the change originally proposed in #251.

  • Duplicate Of: canonical/craft-application#263 (confidence 95%)

    Identical PR body and title; #251 was an unmerged earlier attempt at the same change.

  • Likely Fixed By: canonical/craft-application#154 (confidence 90%)

    The underlying issue (#154, destructive runs should fail on base/host mismatch) was closed by the merged #263.

Related issues

Issue Project State Summary Similarity
#263 feat(lifecycle)!: don't build on incompatible bases craft-application merged Merged PR #263 (b916620e) added lifecycle checks preventing destructive builds when the stored BuildInfo base is incompatible with the host; it fixes #154.
85%
#2569 lifecycle: warn about bases snapcraft merged Merged PR #2569 added lifecycle warnings for projects missing a base or using an incompatible host, resolving LP #1774012.
77%
#898 feat(lifecycle): update UX for unmaintained bases craft-application merged Merged PR #898 as commit 2ed7aae7, updating lifecycle UX for unmaintained bases and adding --ignore=unmaintained support.
73%
#766 fix(lifecycle): don't rebuild on test file changes craft-application merged Merged PR canonical/craft-application#766 excluded spread test files from lifecycle outdated checks, preventing test-only changes from repulling local source parts and resolving #756.
71%