fix: don't duplicate lifecycle progress messages
Metadata
Current evaluation
Merged into main following two approvals and passing CI. The change prevents duplicate lifecycle progress messages across three files. Code coverage remains at 99.01% with 100% diff coverage.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main following two approvals and passing CI. The change prevents duplicate lifecycle progress messages across three files. Code coverage remains at 99.01% with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. The fix prevents duplication of lifecycle progress messages. Codecov confirmed 100% diff coverage with no overall regression. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #62 fix: improve lifecycle messages | craft-application | merged | Merged into main after two approvals. Improved lifecycle messages and expanded human-readable text with all variances across three files. Minor coverage decrease was dismissed as a Codecov artifact. | |
| #4461 fix: improve lifecycle messages | snapcraft | merged | Merged after approval and passing CI. The change improves lifecycle messages by refactoring progress emission from open_stream to explicit progress calls, maintaining code coverage. | |
| #4431 feat: improve lifecycle messages | snapcraft | merged | Merged into main following approval from two reviewers and passing CI checks. The change improves lifecycle messages across six files (+61/-54 lines) with 87.50% diff coverage. | |
| #98 some minor lifecycle papercuts | craft-application | merged | Merged into main after two approvals and passing CI. Adds a progress message during lifecycle initialization and exposes ProjectInfo for testing. The commit introduces 14 lines across two files with 100% diff coverage. | |
| #103 fix: use progress for the packing messages | craft-application | merged | Merged fix replacing the appending Packing message with a progress indicator that overwrites previous output. Approved by two reviewers, passed CI, and achieved 100% diff coverage across seven changed files. | |
| #52 lifecycle: emit progress for packing | craft-application | merged | Merged into main. Adds progress emission during packing to prevent a long ticker on the Lifecycle finished message. Approved by two reviewers, passed CI, and modified two files with two added lines. | |
| #4452 test(spread): check for new lifecycle message | snapcraft | merged | Merged a test update to verify a new lifecycle message, resolving a regression from #4431. Approved by two reviewers with passing CI and stable coverage. The fix unblocks PR #4450. | |
| #4584 lifecycle commands | snapcraft | merged | Merged implementation of lifecycle commands. Approved by two reviewers, passed all CI checks, and modified 15 files with full test coverage. |