← Back to issue list

fix: improve lifecycle messages

View original Github issue

Metadata

Project
snapcraft
Number
#4461
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. The change improves lifecycle messages by refactoring progress emission from open_stream to explicit progress calls, maintaining code coverage.

Suggested action:

No scores available.

Issue body

Wipe "Initializing lifecycle" when parts steps start making progress by moving the action message from the emit.open_stream call to an explicit emit.progress. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI. The change improves lifecycle messages by refactoring progress emission from open_stream to explicit progress calls, maintaining code coverage.
qwen3.6-35b-a3b-mtp-q6 Merged fix improving lifecycle messages by moving the initialization action from emit.open_stream to emit.progress. The change passed all tests, achieved full code coverage, and was successfully merged.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that improves lifecycle messages by moving an action message to emit.progress, ensuring the initializing prompt clears when parts begin building. The change passed unit tests and code coverage checks before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#62 fix: improve lifecycle messages craft-application merged Merged into main after two approvals. Improved lifecycle messages and expanded human-readable text with all variances across three files. Minor coverage decrease was dismissed as a Codecov artifact.
85%
#121 fix: don't duplicate lifecycle progress messages craft-application merged Merged into main following two approvals and passing CI. The change prevents duplicate lifecycle progress messages across three files. Code coverage remains at 99.01% with 100% diff coverage.
84%
#4431 feat: improve lifecycle messages snapcraft merged Merged into main following approval from two reviewers and passing CI checks. The change improves lifecycle messages across six files (+61/-54 lines) with 87.50% diff coverage.
83%
#203 fix: clear prefix for message() and error() craft-cli merged Merged fix for issue #202 correcting a bug where progress and message emissions routed carriage returns to the wrong stream. Changes clear prefixes for message() and error(), passed CI, received two approvals, and improved test coverage.
75%
#52 lifecycle: emit progress for packing craft-application merged Merged into main. Adds progress emission during packing to prevent a long ticker on the Lifecycle finished message. Approved by two reviewers, passed CI, and modified two files with two added lines.
75%
#726 Show lifecycle step progress (and related fix for always getting the instance logs). charmcraft merged Merged changes adding lifecycle step progress display and fixing instance log capture on success and error. Uses Emitter.pause() to ensure logs are always captured. Consolidates output messages and improves zip file logging. Approved and passed CI checks.
73%
#4452 test(spread): check for new lifecycle message snapcraft merged Merged a test update to verify a new lifecycle message, resolving a regression from #4431. Approved by two reviewers with passing CI and stable coverage. The fix unblocks PR #4450.
72%
#757 fix(testing): improve testing messages craft-application merged Merged after two approvals and passing all CI checks. The update improves testing success reporting and provides clearer error messages on failure.
71%
#98 some minor lifecycle papercuts craft-application merged Merged into main after two approvals and passing CI. Adds a progress message during lifecycle initialization and exposes ProjectInfo for testing. The commit introduces 14 lines across two files with 100% diff coverage.
70%