ci(spread): quote pid variables in discard step
Metadata
Current evaluation
Merged PR quoting $pid in .github/workflows/spread.yaml discard step (kill -9 "$pid", spread -discard -reuse-pid="$pid") to fix SC2086 shellcheck/actionlint finding.
Resolution: closed resolved
Reason: PR #1210 was approved and merged, applying a +2/-2 change to quote $pid variables in the Discard spread workers step, resolving the SC2086/actionlint finding.
Evaluated by: mr-cal-bot
No scores available.
Issue body
🤖 This is a preparation PR for the Starbase sync, addressing a pre-existing shellcheck/actionlint finding in `.github/workflows/spread.yaml`.
### Summary
- Quotes `"$pid"` in `kill -9 "$pid"` and `spread -discard -reuse-pid="$pid"` in the `Discard spread workers` step to prevent globbing and word splitting (SC2086).
- Resolves the actionlint error surfaced when Starbase's actionlint tooling is added.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed resolved | Merged PR quoting $pid in .github/workflows/spread.yaml discard step (kill -9 "$pid", spread -discard -reuse-pid="$pid") to fix SC2086 shellcheck/actionlint finding. | |
| ~deepseek/deepseek-pro-latest |
Impact:
20
Quick Win:
17
Complexity:
5
Confidence:
95
Actionability:
90
|
needs review | Quotes "$pid" in the spread.yaml discard step to fix SC2086/actionlint; approved, CI passing, no unresolved comments. | |
| ~deepseek/deepseek-pro-latest |
Impact:
15
Quick Win:
13
Complexity:
5
Confidence:
92
Actionability:
90
|
needs review | Quotes "$pid" in the spread.yaml discard step to fix SC2086 globbing/word-splitting and a pending actionlint error. Approved, CI green, awaiting merge. | |
| ~deepseek/deepseek-pro-latest |
Impact:
20
Quick Win:
15
Complexity:
5
Confidence:
90
Actionability:
80
|
needs review | Quotes $pid in the spread.yaml discard step to fix SC2086/actionlint; approved, one unrelated openstack spread test failing. | |
| ~deepseek/deepseek-pro-latest |
Impact:
10
Quick Win:
8
Complexity:
5
Confidence:
95
Actionability:
88
|
needs review | Quotes $pid in the Discard spread workers step of .github/workflows/spread.yaml to fix SC2086/actionlint globbing/word-splitting warnings. CI green, awaiting review. | |
| ~deepseek/deepseek-pro-latest |
Impact:
15
Quick Win:
12
Complexity:
5
Confidence:
90
Actionability:
85
|
needs review | Quotes "$pid" in the kill and spread -discard commands of the Discard spread workers step in .github/workflows/spread.yaml, fixing SC2086/actionlint. CI passing, awaiting review. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #482 ci: always discard spread workers | rockcraft | merged | PR #482 by lengau merged: added an always-run "Discard spread workers" cleanup step (spread -discard -reuse-pid) to .github/workflows/spread.yaml, copied from snapcraft's spread.yml. |