ci: always discard spread workers
Metadata
Current evaluation
PR #482 by lengau merged: added an always-run "Discard spread workers" cleanup step (spread -discard -reuse-pid) to .github/workflows/spread.yaml, copied from snapcraft's spread.yml.
Resolution: closed resolved
Reason: The PR was approved by 2 reviewers and merged; the resulting change is visible in .github/workflows/spread.yaml as a 'Discard spread workers' step guarded by if: always() (grep hit at line 85). The author confirmed in a comment that it ensures workers are discarded even on cancelled workflow runs.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
A direct copy of: https://github.com/snapcore/snapcraft/blob/main/.github/workflows/spread.yml#L117
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #482 by lengau merged: added an always-run "Discard spread workers" cleanup step (spread -discard -reuse-pid) to .github/workflows/spread.yaml, copied from snapcraft's spread.yml. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged CI changes to always discard Spread workers, including after workflow cancellation, following Snapcraft's cleanup pattern. The -discard option removes reuse files; runner cleanup deletes the worker directory. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #482 as e42d8df9, updating CI to always discard spread workers, including after workflow cancellation. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a CI workflow update to always discard spread workers, ensuring cleanup even on workflow cancellation. This change mirrors snapcraft's spread configuration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to ensure CI spread workers are always discarded, even on workflow cancellation. Aligns with upstream snapcraft configuration and relies on runner cleanup as a fallback. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft#11260
(confidence 35%)
Upstream snapcraft spread.yml line 117 cited in the PR body as the source of the change; propagates the same always-discard pattern to rockcraft
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #115 ci: always discard spread workers in build-rock tests (core22-8) | snapcraft-rocks | merged | PR #115 merged (+8/-0): adds an always-run 'Discard spread workers' step to the spread-tests job in .github/workflows/build-rock.yaml for core22-8, so cancelled/crashed jobs no longer leak spread GCP VMs (SNAPCRAFT-1368). | |
| #116 ci: always discard spread workers in build-rock tests (core22-7) | snapcraft-rocks | open | Adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in .github/workflows/build-rock.yaml (core22-7) so GCP VMs aren't leaked on cancellation (SNAPCRAFT-1368). +8/-0, spread-tests green, build-rock amd64/arm64 failing. | |
| #2771 ci: always discard spread workers in snap-store-tests (main) | charmcraft | merged | Merged PR #2771 (main) adds an always-run "Discard spread workers" cleanup step to the snap-store-tests job in spread.yaml, so cancelled/crashed CI runs no longer leak GCE VMs until the 2h halt timeout. | |
| #117 ci: always discard spread workers in build-rock tests (core24-8) | snapcraft-rocks | merged | Merged PR #117 (core24-8) adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in build-rock.yaml, so cancelled/crashed jobs don't leak GCP VMs for 2h (SNAPCRAFT-1368). Approved; +8/-0. | |
| #1519 ci: always discard spread runners | charmcraft | merged | Merged #1519 (commit fdf24383), adding post-job cleanup to the Spread workflow so temporary runners are always discarded after CI jobs. | |
| #6335 ci: always discard spread workers in manual tests (main) | snapcraft | merged | Merged #6335 in commit b36b3c325, adding always-run Spread worker cleanup to manual CI jobs so cancelled or crashed tests do not leak GCP VMs. | |
| #2615 spread: use more workers to reduce job times | snapcraft | merged | Merged PR #2615 by cjp256 (commit 5c91f9681) bumped spread worker counts in spread.yaml to shorten job times; approved and merged into master. | |
| #1210 ci(spread): quote pid variables in discard step | craft-application | merged | Merged PR quoting $pid in .github/workflows/spread.yaml discard step (kill -9 "$pid", spread -discard -reuse-pid="$pid") to fix SC2086 shellcheck/actionlint finding. | |
| #1220 ci: always run spread workflow on schedule | rockcraft | merged | PR #1220 by medubelko merged (commit 4f2ec54b) into main: adds `|| github.event_name == 'schedule'` to the snap-build, upload-artifact and source-spread-tests conditions in .github/workflows/spread.yaml so bi-daily main runs always execute the full Spread suite. |