← Back to issue list

feat: post-prime hook for LifecycleService

View original Github issue

Metadata

Project
craft-application
Number
#138
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged feature adding a post-prime hook to LifecycleService. Approved by two reviewers, maintaining 99.18% test coverage. Changes span two files with a net addition of 55 lines.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged feature adding a post-prime hook to LifecycleService. Approved by two reviewers, maintaining 99.18% test coverage. Changes span two files with a net addition of 55 lines.
qwen3.6-35b-a3b-mtp-q6 Merged a feature adding a post-prime hook to LifecycleService. All modified lines passed tests, maintaining 99.18% code coverage. The change was successfully integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#57 test: unit tests for lifecycle service debcraft open Adds unit tests for the Lifecycle service (prime_dirs, get_prime_dir, partition-to-package mapping) per review feedback on #54. Merged main in Dec 2025 to resolve conflicts; CI mostly green but Conventional Commits and lint checks still failing. No maintainer review yet.
71%
#727 fix: only run post prime in the process that ran the lifecycle craft-application merged Merged a fix ensuring the post prime lifecycle step only runs in the initiating process, resolving #716 and CRAFT-4425. Approved by three reviewers with passing CI checks. A reviewer suggested adding a spread test later.
71%