← Back to issue list

feat: customise command config

View original Github issue

Metadata

Project
craft-application
Number
#145
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #145 added overridable command configuration via Application.app_config, fixing #125; merged as commit 08220107.

Resolution: closed resolved

Reason: PR #145 was approved and merged as commit 08220107. It introduced an overridable app_config property used when loading commands and explicitly fixed #125.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #125 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #145 added overridable command configuration via Application.app_config, fixing #125; merged as commit 08220107.
stealth/space-bunny-alpha — closed resolved PR #145 by lengau merged as commit 08220107, adding an overridable Application.app_config property so apps can customise the config passed to dispatcher.load_command. Closes craft-application#125.
stealth/space-bunny-alpha — closed resolved PR #145 merged in commit 08220107, enabling command config customization and resolving #125. Modified lines retained 99.02% coverage.
qwen/qwen3.6-35b-a3b — — Merged to implement customizable command configuration, resolving issue #125. Approved by two reviewers, passed CI, and maintained 99.02% test coverage across a 14-line addition and 6-line removal.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#125 (confidence 100%)

    The PR body states “Fixes #125”; the issue requested custom configuration support for command loading.

Related issues

Issue Project State Summary Similarity
#125 Allow custom config to be sent to the command craft-application closed Added an overridable Application.app_config property for customizing dispatcher.load_command without overriding run; merged in canonical/craft-application#145 via commit 08220107.
74%
#196 feat: allow the application to choose the help order of commands craft-cli merged Merged PR #196 as commit a88b353, adding application-configurable command help order and fixing #195.
71%