← Back to issue list

Allow custom config to be sent to the command

View original Github issue

Metadata

Project
craft-application
Number
#125
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Added an overridable Application.app_config property for customizing dispatcher.load_command without overriding run; merged in canonical/craft-application#145 via commit 08220107.

Resolution: closed resolved

Reason: The requested extension point was implemented and merged in canonical/craft-application#145 as commit 08220107. Application.run now uses the overridable app_config property when loading the command.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Allow the dictionary sent to `dispatcher.load_command` in `Application.run` to be overridden without overriding the whole method. See: https://github.com/canonical/charmcraft/pull/1340#discussion_r1370157553 ### Why it needs to get done Currently we have to override the whole method, which is suboptimal.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Added an overridable Application.app_config property for customizing dispatcher.load_command without overriding run; merged in canonical/craft-application#145 via commit 08220107.
stealth/space-bunny-alpha — closed resolved Added an overridable Application.app_config for customizing dispatcher.load_command without replacing Application.run; fixed by merged PR #145 (commit 08220107).
stealth/space-bunny-alpha — closed resolved Added an overridable app_config property for customizing the configuration passed to dispatcher.load_command without replacing Application.run.
stealth/space-bunny-alpha — closed resolved Added an overridable app_config property for customizing dispatcher.load_command without replacing Application.run. Merged in craft-application PR #145 via commit 08220107.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The feature request to allow overriding the config dict passed to dispatcher.load_command in Application.run was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without implementation or discussion. The feature to allow custom config overrides for dispatcher.load_command was abandoned or superseded by subsequent changes.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#145 (confidence 100%)

    Merged PR titled "feat: customise command config" introduced the app_config property.

  • Related To: canonical/charmcraft#1340 (confidence 95%)

    A review discussion there motivated avoiding a full Application.run override.

Related issues

Issue Project State Summary Similarity
#145 feat: customise command config craft-application merged Merged PR #145 added overridable command configuration via Application.app_config, fixing #125; merged as commit 08220107.
74%