← Back to issue list

feat: extensible commands

View original Github issue

Metadata

Project
craft-application
Number
#147
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #147 merged into main as commit 440fdcfd: added extensible commands so apps register parser fillers, prologues and epilogues, with lifecycle commands rebuilt on that framework for charmcraft's changeover.

Resolution: closed resolved

Reason: Merged into main by maintainer lengau after 2 approvals; commit 440fdcfd ("feat: extensible commands (#147)") adds parser fillers, prologues and epilogues and re-implements lifecycle commands on top of them, satisfying the PR's stated goal of unblocking charmcraft's craft-application changeover.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This creates a version of commands that can be modified by the application by registering parser fillers, prologues and epilogues. Additionally, it makes the lifecycle commands versions of these. This is needed to support charmcraft's craft-application changeover, but is kept in draft until I can test it with charmcraft. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #147 merged into main as commit 440fdcfd: added extensible commands so apps register parser fillers, prologues and epilogues, with lifecycle commands rebuilt on that framework for charmcraft's changeover.
stealth/space-bunny-alpha — closed resolved Merged extensible command support in commit 440fdcfd, enabling parser fillers, prologues and epilogues; lifecycle commands now use the framework.
stealth/space-bunny-alpha — closed resolved PR merged as commit 440fdcfd: added extensible commands to craft-application, allowing apps to register parser fillers, prologues and epilogues; lifecycle commands reimplemented on this framework.
stealth/space-bunny-alpha — closed resolved Merged extensible commands, letting applications register parser fillers, prologues and epilogues; lifecycle commands now use this framework. Commit 440fdcfd.
qwen/qwen3.6-35b-a3b — — Merged extensible commands allowing applications to register parser fillers, prologues, and epilogues. Approved by two reviewers with passing CI and full test coverage. Added +376/-42 lines across seven files to support charmcraft transition.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#574 (confidence 45%)

    Later add_command_group ordering work builds on the extensible command-group infrastructure introduced here.

Related issues

No related issues found above the similarity threshold.