← Back to issue list

Pass through certain environment variables to the provider

View original Github issue

Metadata

Project
craft-application
Number
#151
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Environment-variable forwarding was added in canonical/craft-application#260; #151 was closed after declarative default variables were deemed unnecessary.

Resolution: closed resolved

Reason: PR #260 landed the framework needed for applications to forward provider environment variables and define defaults. The maintainer closed #151 after concluding that making those defaults declarative was unnecessary.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done [canonical/rockcraft@`2b711d6` (#412)](https://github.com/canonical/rockcraft/pull/412/commits/2b711d65d4b8e7f0b7ac51ebbac7ee84497b9b9b#diff-e88fd330f53ed49fd6d31921d142a6b45e38b56a50b9dd591a071405e357ae74R37-R44) craft-application should pass through those environment variables (and maybe a few more) automatically. ### Why it needs to get done Every app is doing this on its own.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Environment-variable forwarding was added in canonical/craft-application#260; #151 was closed after declarative default variables were deemed unnecessary.
stealth/space-bunny-alpha — closed resolved Environment-variable forwarding landed in merged PR #260 (commit c70425d9); #151 was closed after deciding additional declarative defaults were unnecessary.
stealth/space-bunny-alpha — closed not a bug Declarative default environment variables were deemed unnecessary after forwarding support landed in canonical/craft-application#260; the request was closed without additional defaults.
stealth/space-bunny-alpha — closed not a bug Closed as unnecessary: provider environment-variable passthrough and configurable defaults already existed, so no additional automatic pass-through was implemented.
qwen/qwen3.6-35b-a3b — — Rejected. Maintainers closed the request, noting craft-application already provides a framework for passing environment variables. Additional declarative handling was deemed unnecessary, leaving the issue unimplemented.
qwen/qwen3.6-35b-a3b — — Rejected. Maintainer noted an existing framework already handles environment variable passing and allows adding defaults, making further declarative changes unnecessary for now.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#260 (confidence 96%)

    The PR added provider environment-variable forwarding support referenced by the closing discussion.

Related issues

Issue Project State Summary Similarity
#260 feat: pass environment variables to the instance. craft-application merged Merged PR #260 as commit c70425d9, forwarding proxy variables to the provider and demonstrating application-defined instance variables; fixes #258 (CRAFT-2579).
78%