feat: pass environment variables to the instance.
Metadata
Current evaluation
Merged PR #260 as commit c70425d9, forwarding proxy variables to the provider and demonstrating application-defined instance variables; fixes #258 (CRAFT-2579).
Resolution: closed resolved
Reason: PR #260 was approved and merged without unresolved review threads. Merge commit c70425d9 implements the environment-variable forwarding and explicitly states that it fixes #258.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This provides two things:
1. Forwards proxy variables to the provider.
2. Provides an example for how an application can forward additional variables.
Fixes #258 (CRAFT-2579)
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #260 as commit c70425d9, forwarding proxy variables to the provider and demonstrating application-defined instance variables; fixes #258 (CRAFT-2579). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #260 in commit c70425d9 added environment-variable forwarding for providers and instances, including proxy variables, fixing #258. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #260 added provider and instance environment-variable forwarding, including proxy variables, and fixed #258. Additional dynamic forwarding was deferred to a future PR. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR forwarding proxy and additional environment variables to the instance provider, resolving #258. Approved by three reviewers and passed CI. Adds 71 lines across three files. Dynamic variable forwarding deferred to a future PR. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#258
(confidence 100%)
The PR description explicitly identifies #258 as fixed.
-
Related To:
canonical/craft-providers#528
(confidence 75%)
The issue tracker identifies later upstream proxy-injection work in craft-providers as the superseding resolution path for #258.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #151 Pass through certain environment variables to the provider | craft-application | closed | Environment-variable forwarding was added in canonical/craft-application#260; #151 was closed after declarative default variables were deemed unnecessary. | |
| #765 feat: pass config values to the inner instance as environment variables | craft-application | merged | Merged PR #765 as commit 42945e65, passing config values to the inner instance via environment variables and fixing #777 by accounting for extra proxy variables in tests. | |
| #258 Proxy-related environment variables are not being forwarded to managed instances | craft-application | closed | Fixed by merged PR #260 (commit c70425d9), which forwards host proxy environment variables into managed instances; linked to originating report craft-providers#528. | |
| #921 feat: forward environment variable to inner instance | craft-application | closed | PR #921 was closed unmerged so environment-variable and related variable work could be consolidated elsewhere. |