← Back to issue list

Managed runs with empty build plans should fail

View original Github issue

Metadata

Project
craft-application
Number
#225
Type
issue
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Managed runs now fail with EmptyBuildPlanError when filtering leaves no build-plan items, fixing the silent-success behavior in merged PR #437.

Resolution: closed resolved

Reason: Merged PR canonical/craft-application#437 changed the managed-run path to raise EmptyBuildPlanError instead of succeeding with an empty plan. The fix is recorded in commits 2fe26ce0 and 5e7560e4.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description The current code that loops over the build plan to launch managed runs just no-ops if the plan is empty (like if all build infos were filtered out). I can't think of a case where that shouldn't be an error instead, specially since we've decided that trying to build an empty plan in destructive mode is an error. ### To Reproduce Create a project with a build plan that will get totally filtered out (eg only builds on `arm64` and you're on `amd64`) ### part yaml ```shell . ``` ### Relevant log output ```shell . ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Managed runs now fail with EmptyBuildPlanError when filtering leaves no build-plan items, fixing the silent-success behavior in merged PR #437.
stealth/space-bunny-alpha — closed resolved Fixed in merged PR #437: managed runs now raise EmptyBuildPlanError instead of silently succeeding when no build-plan items remain after filtering.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The bug causing empty build plans to silently no-op instead of failing was not addressed. No fix or discussion preceded closure.
qwen/qwen3.6-35b-a3b — — Requesting empty build plans to fail instead of no-op was closed without resolution. No fix or pull request was implemented, indicating the report was abandoned.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#437 (confidence 99%)

    The merged PR directly implements the requested failure for empty filtered build plans.

Related issues

Issue Project State Summary Similarity
#437 fix: fail managed runs if the build plan is empty craft-application merged Merged PR #437 makes managed runs raise EmptyBuildPlanError when filtering leaves no builds, preventing false success and fixing #225.
90%