fix: fail managed runs if the build plan is empty
Metadata
Current evaluation
Merged PR #437 makes managed runs raise EmptyBuildPlanError when filtering leaves no builds, preventing false success and fixing #225.
Resolution: closed resolved
Reason: PR #437 was approved and merged. It adds EmptyBuildPlanError so managed runs fail on an empty filtered build plan and advise checking platforms and command-line parameters.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This fix addresses cases like, for example, a project that only builds on `amd64` being built on `riscv64`. Previously the call to run_managed() would loop over the (empty) build plan and then finish "successfully". This new version will raise an EmptyBuildPlanError indicating to the user that they should check the project's 'platforms' declaration and the command-line parameters.
Fixes #225
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #437 makes managed runs raise EmptyBuildPlanError when filtering leaves no builds, preventing false success and fixing #225. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #437 makes managed runs raise EmptyBuildPlanError when filtering leaves no build-plan items, resolving #225 instead of silently succeeding. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #437 to make managed runs raise EmptyBuildPlanError when platform filters yield no builds, fixing #225 instead of silently succeeding. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #437: managed runs now raise EmptyBuildPlanError when filtering leaves an empty build plan, fixing #225; released in 4.1.2. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-application#437 makes managed runs raise EmptyBuildPlanError instead of silently succeeding when no build-plan items match, fixing #225. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR resolves issue #225 by raising an EmptyBuildPlanError when the build plan is empty, preventing silent success. Approved by two reviewers and passed CI. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#225
(confidence 100%)
PR #437 explicitly states that it fixes #225, which is now closed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #225 Managed runs with empty build plans should fail | craft-application | closed | Managed runs now fail with EmptyBuildPlanError when filtering leaves no build-plan items, fixing the silent-success behavior in merged PR #437. |